Skip to content

Commit 00e6ad4

Browse files
committed
More shards
Signed-off-by: Dmitry Rogozhkin <[email protected]>
1 parent 1f71411 commit 00e6ad4

File tree

1 file changed

+23
-4
lines changed

1 file changed

+23
-4
lines changed

.github/workflows/_linux_transformers.yml

Lines changed: 23 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -213,17 +213,36 @@ jobs:
213213
# Excluding tests due to:
214214
# * https://github.com/pytorch/pytorch/issues/140965 (aten::_linalg_eigvals)
215215
# * https://github.com/huggingface/transformers/issues/36267 (marian tests)
216+
#
217+
# NOTE: IMPORTANT! Read before updating.
218+
# Be careful reducing number of shards. We saw "Fatal Python error" on 4
219+
# shards which was causing CI test hang and exit by timeout after 6h. Issue
220+
# was happening on the `--shard-id 1` on this test:
221+
# tests/models/qwen2_5_vl/test_modeling_qwen2_5_vl.py::Qwen2_5_VLModelTest::test_constrained_beam_search_generate_dict_output
222+
# Test passes if executed standalone. Likely we step into some resource limit or a leak.
216223
- test_case: 'tests_models_0'
217-
cmd: 'tests/models --num-shards 4 --shard-id 0 --ignore=tests/models/marian/test_modeling_marian.py'
224+
cmd: 'tests/models --num-shards 8 --shard-id 0 --ignore=tests/models/marian/test_modeling_marian.py'
218225
filter: 'not test_resize_embeddings_untied and not test_resize_tokens_embeddings'
219226
- test_case: 'tests_models_1'
220-
cmd: 'tests/models --num-shards 4 --shard-id 1 --ignore=tests/models/marian/test_modeling_marian.py'
227+
cmd: 'tests/models --num-shards 8 --shard-id 1 --ignore=tests/models/marian/test_modeling_marian.py'
221228
filter: 'not test_resize_embeddings_untied and not test_resize_tokens_embeddings'
222229
- test_case: 'tests_models_2'
223-
cmd: 'tests/models --num-shards 4 --shard-id 2 --ignore=tests/models/marian/test_modeling_marian.py'
230+
cmd: 'tests/models --num-shards 8 --shard-id 2 --ignore=tests/models/marian/test_modeling_marian.py'
224231
filter: 'not test_resize_embeddings_untied and not test_resize_tokens_embeddings'
225232
- test_case: 'tests_models_3'
226-
cmd: 'tests/models --num-shards 4 --shard-id 3 --ignore=tests/models/marian/test_modeling_marian.py'
233+
cmd: 'tests/models --num-shards 8 --shard-id 3 --ignore=tests/models/marian/test_modeling_marian.py'
234+
filter: 'not test_resize_embeddings_untied and not test_resize_tokens_embeddings'
235+
- test_case: 'tests_models_4'
236+
cmd: 'tests/models --num-shards 8 --shard-id 4 --ignore=tests/models/marian/test_modeling_marian.py'
237+
filter: 'not test_resize_embeddings_untied and not test_resize_tokens_embeddings'
238+
- test_case: 'tests_models_5'
239+
cmd: 'tests/models --num-shards 8 --shard-id 5 --ignore=tests/models/marian/test_modeling_marian.py'
240+
filter: 'not test_resize_embeddings_untied and not test_resize_tokens_embeddings'
241+
- test_case: 'tests_models_6'
242+
cmd: 'tests/models --num-shards 8 --shard-id 6 --ignore=tests/models/marian/test_modeling_marian.py'
243+
filter: 'not test_resize_embeddings_untied and not test_resize_tokens_embeddings'
244+
- test_case: 'tests_models_7'
245+
cmd: 'tests/models --num-shards 8 --shard-id 7 --ignore=tests/models/marian/test_modeling_marian.py'
227246
filter: 'not test_resize_embeddings_untied and not test_resize_tokens_embeddings'
228247
# Excluding tests due to:
229248
# * Some ray tests hang, reason unknown

0 commit comments

Comments
 (0)