Skip to content

Commit 2ae8d89

Browse files
committed
Remove renaming artifacts
Signed-off-by: Dmitry Sidorov <[email protected]>
1 parent 2b8bf0d commit 2ae8d89

File tree

6 files changed

+15
-13
lines changed

6 files changed

+15
-13
lines changed

clang/include/clang/AST/Type.h

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -480,8 +480,10 @@ class Qualifiers {
480480
// Otherwise in OpenCLC v2.0 s6.5.5: every address space except
481481
// for __constant can be used as __generic.
482482
(A == LangAS::opencl_generic && B != LangAS::opencl_constant) ||
483-
// For USM extension we define global_device and global_host address
484-
// spaces, which are a subset of __global.
483+
// We also define global_device and global_host address spaces,
484+
// to distinguish global pointers allocated on host to pointers
485+
// allocated on device, which are a subset of __global.
486+
// FIXME: add a reference to spec when ready
485487
(A == LangAS::opencl_global && (B == LangAS::opencl_global_device ||
486488
B == LangAS::opencl_global_host)) ||
487489
// Consider pointer size address spaces to be equivalent to default.

clang/include/clang/Basic/Attr.td

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1296,12 +1296,12 @@ def OpenCLGlobalAddressSpace : TypeAttr {
12961296

12971297
def OpenCLGlobalDeviceAddressSpace : TypeAttr {
12981298
let Spellings = [Clang<"opencl_global_device">];
1299-
let Documentation = [OpenCLUSMAddressSpacesDocs];
1299+
let Documentation = [OpenCLGlobalAddressSpacesDocs];
13001300
}
13011301

13021302
def OpenCLGlobalHostAddressSpace : TypeAttr {
13031303
let Spellings = [Clang<"opencl_global_host">];
1304-
let Documentation = [OpenCLUSMAddressSpacesDocs];
1304+
let Documentation = [OpenCLGlobalAddressSpacesDocs];
13051305
}
13061306

13071307
def OpenCLLocalAddressSpace : TypeAttr {

clang/include/clang/Basic/AttrDocs.td

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3559,7 +3559,7 @@ scope) variables and static local variable as well.
35593559
}];
35603560
}
35613561

3562-
def OpenCLUSMAddressSpacesDocs : Documentation {
3562+
def OpenCLGlobalAddressSpacesDocs : Documentation {
35633563
let Category = DocOpenCLAddressSpaces;
35643564
let Heading = "[[clang::opencl_global_device]], [[clang::opencl_global_host]]";
35653565
let Content = [{

clang/lib/AST/ItaniumMangle.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2393,10 +2393,10 @@ void CXXNameMangler::mangleQualifiers(Qualifiers Quals, const DependentAddressSp
23932393
ASString = "CLglobal";
23942394
break;
23952395
case LangAS::opencl_global_device:
2396-
ASString = "CLUSMDevice";
2396+
ASString = "CLDevice";
23972397
break;
23982398
case LangAS::opencl_global_host:
2399-
ASString = "CLUSMHost";
2399+
ASString = "CLHost";
24002400
break;
24012401
case LangAS::opencl_local:
24022402
ASString = "CLlocal";

clang/lib/AST/MicrosoftMangle.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1824,10 +1824,10 @@ void MicrosoftCXXNameMangler::mangleAddressSpaceType(QualType T,
18241824
Extra.mangleSourceName("_ASCLglobal");
18251825
break;
18261826
case LangAS::opencl_global_device:
1827-
Extra.mangleSourceName("_ASCLUSMDevice");
1827+
Extra.mangleSourceName("_ASCLDevice");
18281828
break;
18291829
case LangAS::opencl_global_host:
1830-
Extra.mangleSourceName("_ASCLUSMHost");
1830+
Extra.mangleSourceName("_ASCLHost");
18311831
break;
18321832
case LangAS::opencl_local:
18331833
Extra.mangleSourceName("_ASCLlocal");

clang/test/CodeGenCXX/mangle-address-space.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -66,11 +66,11 @@ __constant float *ocl_f1(char __generic const *p) { return 0;}
6666
// WINOCL-LABEL: define {{.*}}float* @"?ocl_f2@@YAPEAU?$_ASCLgeneric@$$CAM@__clang@@QEAU?$_ASCLgeneric@$$CBD@2@@Z"
6767
__generic float *ocl_f2(__generic char const * const p) { return 0;}
6868

69-
// CHECKOCL-LABEL: define {{.*}}void @_Z6ocl_f3PU9CLUSMHost14ocl_OpaqueType
70-
// WINOCL-LABEL: define {{.*}}void @"?ocl_f3@@YAXPEAU?$_ASCLUSMHost@$$CAUocl_OpaqueType@@@__clang@@@Z"
69+
// CHECKOCL-LABEL: define {{.*}}void @_Z6ocl_f3PU6CLHost14ocl_OpaqueType
70+
// WINOCL-LABEL: define {{.*}}void @"?ocl_f3@@YAXPEAU?$_ASCLHost@$$CAUocl_OpaqueType@@@__clang@@@Z"
7171
void ocl_f3(ocl_OpaqueTypePtrH) {}
7272

73-
// CHECKOCL-LABEL: define {{.*}}void @_Z6ocl_f4PU11CLUSMDevice14ocl_OpaqueType
74-
// WINOCL-LABEL: define {{.*}}void @"?ocl_f4@@YAXPEAU?$_ASCLUSMDevice@$$CAUocl_OpaqueType@@@__clang@@@Z"
73+
// CHECKOCL-LABEL: define {{.*}}void @_Z6ocl_f4PU8CLDevice14ocl_OpaqueType
74+
// WINOCL-LABEL: define {{.*}}void @"?ocl_f4@@YAXPEAU?$_ASCLDevice@$$CAUocl_OpaqueType@@@__clang@@@Z"
7575
void ocl_f4(ocl_OpaqueTypePtrD) {}
7676
#endif

0 commit comments

Comments
 (0)