Skip to content

Commit 204e5fd

Browse files
Revert "fix: Remove tlb flush from DG2 and MTL"
This reverts commit 8ef4629. Signed-off-by: Compute-Runtime-Validation <[email protected]>
1 parent 147867f commit 204e5fd

File tree

5 files changed

+1
-19
lines changed

5 files changed

+1
-19
lines changed

shared/source/xe_hpg_core/dg2/os_agnostic_product_helper_dg2.inl

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -88,11 +88,6 @@ bool ProductHelperHw<gfxProduct>::isMaxThreadsForWorkgroupWARequired(const Hardw
8888
return DG2::isG10(hwInfo) && GfxCoreHelper::isWorkaroundRequired(REVISION_A0, REVISION_A1, hwInfo, *this);
8989
}
9090

91-
template <>
92-
bool ProductHelperHw<gfxProduct>::isTlbFlushRequired() const {
93-
return false;
94-
}
95-
9691
template <>
9792
void ProductHelperHw<gfxProduct>::setForceNonCoherent(void *const statePtr, const StateComputeModeProperties &properties) const {
9893
using STATE_COMPUTE_MODE = typename XeHpgCoreFamily::STATE_COMPUTE_MODE;

shared/source/xe_hpg_core/mtl/os_agnostic_product_helper_mtl.inl

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -97,11 +97,6 @@ bool ProductHelperHw<gfxProduct>::isDummyBlitWaRequired() const {
9797
return true;
9898
}
9999

100-
template <>
101-
bool ProductHelperHw<gfxProduct>::isTlbFlushRequired() const {
102-
return false;
103-
}
104-
105100
template <>
106101
bool ProductHelperHw<gfxProduct>::isCachingOnCpuAvailable() const {
107102
return false;

shared/test/unit_test/os_interface/product_helper_tests.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -430,7 +430,7 @@ HWTEST2_F(ProductHelperTest, givenProductHelperWhenAskedIfIsTimestampWaitSupport
430430
EXPECT_FALSE(productHelper->isTimestampWaitSupportedForEvents());
431431
}
432432

433-
HWTEST2_F(ProductHelperTest, givenProductHelperWhenAskedIfIsTlbFlushRequiredThenTrueIsReturned, IsNotXeHpgOrXeHpcCore) {
433+
HWTEST2_F(ProductHelperTest, givenProductHelperWhenAskedIfIsTlbFlushRequiredThenTrueIsReturned, IsNotPVC) {
434434
EXPECT_TRUE(productHelper->isTlbFlushRequired());
435435
}
436436

shared/test/unit_test/xe_hpg_core/dg2/test_product_helper_dg2.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,6 @@ DG2TEST_F(Dg2ProductHelper, givenDG2WithBSteppingThenAdditionalStateBaseAddressW
2929
EXPECT_TRUE(isWARequired);
3030
}
3131

32-
DG2TEST_F(Dg2ProductHelper, whenCheckIsTlbFlushRequiredThenReturnProperValue) {
33-
EXPECT_FALSE(productHelper->isTlbFlushRequired());
34-
}
35-
3632
DG2TEST_F(Dg2ProductHelper, givenDG2WithA0SteppingThenMaxThreadsForWorkgroupWAIsRequired) {
3733
pInHwInfo.platform.usRevId = productHelper->getHwRevIdFromStepping(REVISION_A0, pInHwInfo);
3834
for (const auto &devId : dg2G10DeviceIds) {

shared/test/unit_test/xe_hpg_core/mtl/product_helper_tests_mtl.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -83,10 +83,6 @@ MTLTEST_F(MtlProductHelper, givenProductHelperWhenGettingEvictIfNecessaryFlagSup
8383
EXPECT_TRUE(productHelper->isEvictionIfNecessaryFlagSupported());
8484
}
8585

86-
MTLTEST_F(MtlProductHelper, whenCheckIsTlbFlushRequiredThenReturnProperValue) {
87-
EXPECT_FALSE(productHelper->isTlbFlushRequired());
88-
}
89-
9086
MTLTEST_F(MtlProductHelper, givenProductHelperWhenGetCommandsStreamPropertiesSupportThenExpectCorrectValues) {
9187

9288
EXPECT_FALSE(productHelper->getScmPropertyThreadArbitrationPolicySupport());

0 commit comments

Comments
 (0)