From ecc0db9e779b26b3c9ccee6f8711a40e3bfc1e6c Mon Sep 17 00:00:00 2001
From: Ivan Goncharov <ivan.goncharov.ua@gmail.com>
Date: Wed, 29 Mar 2023 22:56:08 +0300
Subject: [PATCH] printSchema: correctly print empty description

Motivation: empty description is definetly a corner case but spec allow them so we should correctly print them
---
 src/utilities/__tests__/printSchema-test.ts | 125 +++++++++++++++++++-
 src/utilities/printSchema.ts                |   4 +-
 2 files changed, 123 insertions(+), 6 deletions(-)

diff --git a/src/utilities/__tests__/printSchema-test.ts b/src/utilities/__tests__/printSchema-test.ts
index 29799a4881..2da58e7d06 100644
--- a/src/utilities/__tests__/printSchema-test.ts
+++ b/src/utilities/__tests__/printSchema-test.ts
@@ -601,16 +601,133 @@ describe('Type System Printer', () => {
     `);
   });
 
-  it('Prints an empty description', () => {
-    const schema = buildSingleFieldSchema({
-      type: GraphQLString,
+  it('Prints an empty descriptions', () => {
+    const args = {
+      someArg: { description: '', type: GraphQLString },
+      anotherArg: { description: '', type: GraphQLString },
+    };
+
+    const fields = {
+      someField: { description: '', type: GraphQLString, args },
+      anotherField: { description: '', type: GraphQLString, args },
+    };
+
+    const queryType = new GraphQLObjectType({
+      name: 'Query',
       description: '',
+      fields,
+    });
+
+    const scalarType = new GraphQLScalarType({
+      name: 'SomeScalar',
+      description: '',
+    });
+
+    const interfaceType = new GraphQLInterfaceType({
+      name: 'SomeInterface',
+      description: '',
+      fields,
+    });
+
+    const unionType = new GraphQLUnionType({
+      name: 'SomeUnion',
+      description: '',
+      types: [queryType],
+    });
+
+    const enumType = new GraphQLEnumType({
+      name: 'SomeEnum',
+      description: '',
+      values: {
+        SOME_VALUE: { description: '' },
+        ANOTHER_VALUE: { description: '' },
+      },
+    });
+
+    const someDirective = new GraphQLDirective({
+      name: 'someDirective',
+      description: '',
+      args,
+      locations: [DirectiveLocation.QUERY],
+    });
+
+    const schema = new GraphQLSchema({
+      description: '',
+      query: queryType,
+      types: [scalarType, interfaceType, unionType, enumType],
+      directives: [someDirective],
     });
 
     expectPrintedSchema(schema).to.equal(dedent`
+      """"""
+      schema {
+        query: Query
+      }
+      
+      """"""
+      directive @someDirective(
+        """"""
+        someArg: String
+
+        """"""
+        anotherArg: String
+      ) on QUERY
+
+      """"""
+      scalar SomeScalar
+
+      """"""
+      interface SomeInterface {
+        """"""
+        someField(
+          """"""
+          someArg: String
+
+          """"""
+          anotherArg: String
+        ): String
+
+        """"""
+        anotherField(
+          """"""
+          someArg: String
+
+          """"""
+          anotherArg: String
+        ): String
+      }
+
+      """"""
+      union SomeUnion = Query
+
+      """"""
       type Query {
         """"""
-        singleField: String
+        someField(
+          """"""
+          someArg: String
+
+          """"""
+          anotherArg: String
+        ): String
+
+        """"""
+        anotherField(
+          """"""
+          someArg: String
+
+          """"""
+          anotherArg: String
+        ): String
+      }
+
+      """"""
+      enum SomeEnum {
+        """"""
+        SOME_VALUE
+
+        """"""
+        ANOTHER_VALUE
       }
     `);
   });
diff --git a/src/utilities/printSchema.ts b/src/utilities/printSchema.ts
index 37cb09eb2e..5e31250a7f 100644
--- a/src/utilities/printSchema.ts
+++ b/src/utilities/printSchema.ts
@@ -82,7 +82,7 @@ function printSchemaDefinition(schema: GraphQLSchema): Maybe<string> {
 
   // Only print a schema definition if there is a description or if it should
   // not be omitted because of having default type names.
-  if (schema.description || !hasDefaultRootOperationTypes(schema)) {
+  if (schema.description != null || !hasDefaultRootOperationTypes(schema)) {
     return (
       printDescription(schema) +
       'schema {\n' +
@@ -234,7 +234,7 @@ function printArgs(
   }
 
   // If every arg does not have a description, print them on one line.
-  if (args.every((arg) => !arg.description)) {
+  if (args.every((arg) => arg.description == null)) {
     return '(' + args.map(printInputValue).join(', ') + ')';
   }