Skip to content

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Mar 25, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards #91 🦕

@tswast tswast requested a review from a team as a code owner March 25, 2022 14:40
@tswast tswast requested review from a team and stephaniewang526 March 25, 2022 14:40
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. label Mar 25, 2022
@tswast tswast added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 25, 2022
@tswast
Copy link
Collaborator Author

tswast commented Mar 25, 2022

"Do Not Merge" added because I want to check that owlbot updates the readme and any other docs that reference preview/beta.

Also, need to "Release-As: 1.0.0" to the commit message.

@tswast tswast added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Mar 25, 2022
@tswast tswast closed this Mar 25, 2022
@tswast tswast reopened this Mar 25, 2022
@tswast tswast merged commit 0363e87 into main Mar 25, 2022
@tswast tswast deleted the prepare-1.0.0 branch March 25, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants