Merge pull request #23 from ericcurtin/fix-bugs

ochafik · web-flow · commit 51a4a07346af · 2025-01-19T00:58:38.000Z
erase functions have bugs
diff --git a/include/minja/minja.hpp b/include/minja/minja.hpp
@@ -367,11 +367,11 @@ class Value : public std::enable_shared_from_this<Value> {
     }
   }
   void erase(size_t index) {
-    if (array_) throw std::runtime_error("Value is not an array: " + dump());
+    if (!array_) throw std::runtime_error("Value is not an array: " + dump());
     array_->erase(array_->begin() + index);
   }
   void erase(const std::string & key) {
-    if (object_) throw std::runtime_error("Value is not an object: " + dump());
+    if (!object_) throw std::runtime_error("Value is not an object: " + dump());
     object_->erase(key);
   }
   const Value& at(const Value & index) const {

Original file line number	Diff line number	Diff line change
`@@ -367,11 +367,11 @@ class Value : public std::enable_shared_from_this<Value> {`
`367`	`367`	`}`
`368`	`368`	`}`
`369`	`369`	`void erase(size_t index) {`
`370`		`- if (array_) throw std::runtime_error("Value is not an array: " + dump());`
	`370`	`+ if (!array_) throw std::runtime_error("Value is not an array: " + dump());`
`371`	`371`	`array_->erase(array_->begin() + index);`
`372`	`372`	`}`
`373`	`373`	`void erase(const std::string & key) {`
`374`		`- if (object_) throw std::runtime_error("Value is not an object: " + dump());`
	`374`	`+ if (!object_) throw std::runtime_error("Value is not an object: " + dump());`
`375`	`375`	`object_->erase(key);`
`376`	`376`	`}`
`377`	`377`	`const Value& at(const Value & index) const {`