Skip to content

Commit b470392

Browse files
authored
Bump to Node 24 (#468)
1 parent 5fe78db commit b470392

File tree

13 files changed

+65
-76
lines changed

13 files changed

+65
-76
lines changed

.github/actionlint.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
paths:
2+
'**/*.yml':
3+
ignore:
4+
# https://github.com/rhysd/actionlint/issues/559
5+
- 'invalid runner name "node24"'

.github/workflows/cleanup.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020
steps:
2121
- uses: 'actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683' # ratchet:actions/checkout@v4
2222

23-
- uses: 'google-github-actions/auth@v2' # ratchet:exclude
23+
- uses: 'google-github-actions/auth@v3' # ratchet:exclude
2424
with:
2525
workload_identity_provider: '${{ vars.WIF_PROVIDER_NAME }}'
2626
service_account: '${{ vars.SERVICE_ACCOUNT_EMAIL }}'

.github/workflows/integration.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ jobs:
3232
- name: 'npm build'
3333
run: 'npm ci && npm run build'
3434

35-
- uses: 'google-github-actions/auth@v2' # ratchet:exclude
35+
- uses: 'google-github-actions/auth@v3' # ratchet:exclude
3636
with:
3737
project_id: '${{ vars.PROJECT_ID }}'
3838
workload_identity_provider: '${{ vars.WIF_PROVIDER_NAME }}'
@@ -62,7 +62,7 @@ jobs:
6262
- name: 'npm build'
6363
run: 'npm ci && npm run build'
6464

65-
- uses: 'google-github-actions/auth@v2' # ratchet:exclude
65+
- uses: 'google-github-actions/auth@v3' # ratchet:exclude
6666
with:
6767
project_id: '${{ vars.PROJECT_ID }}'
6868
workload_identity_provider: '${{ vars.WIF_PROVIDER_NAME }}'

.github/workflows/unit.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ jobs:
4545
run: 'npm ci && npm run build'
4646

4747
- id: 'auth'
48-
uses: 'google-github-actions/auth@v2' # ratchet:exclude
48+
uses: 'google-github-actions/auth@v3' # ratchet:exclude
4949
if: |-
5050
${{ github.event_name == 'push' || github.repository == github.event.pull_request.head.repo.full_name && github.actor != 'dependabot[bot]' }}
5151
with:

README.md

Lines changed: 25 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,6 @@
33
This action deploys your function source code to [Cloud Functions][cloud-functions] and makes the URL
44
available to later build steps via outputs.
55

6-
> [!CAUTION]
7-
>
8-
> **This README corresponds to the "v3" GitHub Action**, which is currently in
9-
> beta. If you are using "v2", see the [documentation for
10-
> google-github-actions/deploy-cloud-functions@v2](https://github.com/google-github-actions/deploy-cloud-functions/tree/release/v2).
11-
126
**This is not an officially supported Google product, and it is not covered by a
137
Google Cloud support contract. To report bugs or request features in a Google
148
Cloud product, please contact [Google Cloud
@@ -21,9 +15,10 @@ support](https://cloud.google.com/support).**
2115
the secrets being requested. See [Authorization](#authorization) for more
2216
information.
2317

24-
- This action runs using Node 20. If you are using self-hosted GitHub Actions
25-
runners, you must use a version of the GitHub Actions runner that supports
26-
Node 20 or higher.
18+
- This action runs using Node 24. If you are using self-hosted GitHub Actions
19+
runners, you must use a [runner
20+
version](https://github.com/actions/virtual-environments) that supports this
21+
version or later.
2722

2823

2924
## Usage
@@ -40,13 +35,13 @@ jobs:
4035
- uses: 'actions/checkout@v4'
4136

4237
- id: 'auth'
43-
uses: 'google-github-actions/auth@v2'
38+
uses: 'google-github-actions/auth@v3'
4439
with:
4540
project_id: 'my-project'
4641
workload_identity_provider: 'projects/123456789/locations/global/workloadIdentityPools/my-pool/providers/my-provider'
4742

4843
- id: 'deploy'
49-
uses: 'google-github-actions/deploy-cloud-functions@v3'
44+
uses: 'google-github-actions/deploy-cloud-functions@v4'
5045
timeout-minutes: 10
5146
with:
5247
name: 'my-function'
@@ -130,7 +125,9 @@ jobs:
130125
- <a name="__input_runtime"></a><a href="#user-content-__input_runtime"><code>runtime</code></a>: _(Required)_ Runtime for the function, such as "nodejs20". For a list of all available
131126
runtimes, run:
132127

133-
$ gcloud functions runtimes list
128+
```sh
129+
$ gcloud functions runtimes list
130+
```
134131

135132
The available runtimes change over time.
136133

@@ -160,10 +157,10 @@ jobs:
160157
- <a name="__input_build_worker_pool"></a><a href="#user-content-__input_build_worker_pool"><code>build_worker_pool</code></a>: _(Optional)_ Name of the Cloud Build Custom Worker Pool that should be used to build
161158
the function. The format of this field is:
162159

163-
projects/<project>/locations/<region>/workerPools/<workerPool>
160+
projects/[PROJECT]/locations/[REGION]/workerPools/[WORKER_POOL]
164161

165-
where `<project>` and `<region>` are the project id and region
166-
respectively where the worker pool is defined and `<workerPool>` is the
162+
where `[PROJECT]` and `[REGION]` are the project id and region
163+
respectively where the worker pool is defined and `[WORKER_POOL]` is the
167164
short name of the worker pool.
168165

169166
If the project ID is not the same as the function, then the Cloud
@@ -177,7 +174,7 @@ jobs:
177174

178175
The value must match the pattern:
179176

180-
projects/<project>/locations/<location>/repositories/<repository>.
177+
projects/[PROJECT]/locations/[LOCATION]/repositories/[REPOSITORY].
181178

182179
Cross-project repositories are not supported. Cross-location repositories
183180
are not supported. Repository format must be 'DOCKER'.
@@ -240,7 +237,6 @@ jobs:
240237
volumes. Keys starting with a forward slash '/' are mount paths. All other
241238
keys correspond to environment variables:
242239

243-
244240
```yaml
245241
with:
246242
secrets: |-
@@ -283,11 +279,15 @@ jobs:
283279
- <a name="__input_event_trigger_type"></a><a href="#user-content-__input_event_trigger_type"><code>event_trigger_type</code></a>: _(Optional)_ Specifies which action should trigger the function. For a list of
284280
acceptable values, run:
285281

286-
$ gcloud functions event-types list
282+
```sh
283+
$ gcloud functions event-types list
284+
```
287285

288286
This usually requires the eventarc API to be enabled:
289287

290-
$ gcloud services enable eventarc.googleapis.com
288+
```sh
289+
$ gcloud services enable eventarc.googleapis.com
290+
```
291291

292292
The available trigger types may change over time.
293293

@@ -319,7 +319,7 @@ jobs:
319319
will trigger function execution with message contents passed as input
320320
data of the format:
321321

322-
projects/<project_id>/topics/<topic_id>
322+
projects/[PROJECT]/topics/[TOPIC]
323323

324324
The service account must have permissions on this topic.
325325

@@ -331,7 +331,7 @@ jobs:
331331

332332
- <a name="__input_event_trigger_channel"></a><a href="#user-content-__input_event_trigger_channel"><code>event_trigger_channel</code></a>: _(Optional)_ The name of the channel associated with the trigger in the format:
333333

334-
projects/<project>/locations/<location>/channels/<channel>
334+
projects/[PROJECT]/locations/[LOCATION]/channels/<channel>
335335

336336
You must provide a channel to receive events from Eventarc SaaS partners.
337337

@@ -355,7 +355,7 @@ service](https://cloud.google.com/functions/docs/securing/managing-access-iam).
355355

356356
- <a name="__output_name"></a><a href="#user-content-__output_name"><code>name</code></a>: Full resource name of the Cloud Function, of the format:
357357

358-
projects/<project>/locations/<location>/functions/<function>
358+
projects/[PROJECT]/locations/[LOCATION]/functions/<function>
359359

360360
- <a name="__output_url"></a><a href="#user-content-__output_url"><code>url</code></a>: The URL of your Cloud Function.
361361

@@ -397,13 +397,13 @@ jobs:
397397
- uses: 'actions/checkout@v4'
398398
399399
- id: 'auth'
400-
uses: 'google-github-actions/auth@v2'
400+
uses: 'google-github-actions/auth@v3'
401401
with:
402402
project_id: 'my-project'
403403
workload_identity_provider: 'projects/123456789/locations/global/workloadIdentityPools/my-pool/providers/my-provider'
404404
405405
- id: 'deploy'
406-
uses: 'google-github-actions/deploy-cloud-functions@v3'
406+
uses: 'google-github-actions/deploy-cloud-functions@v4'
407407
timeout-minutes: 10
408408
with:
409409
name: 'my-function'
@@ -424,7 +424,7 @@ jobs:
424424
- uses: 'actions/checkout@v4'
425425
426426
- id: 'deploy'
427-
uses: 'google-github-actions/deploy-cloud-functions@v3'
427+
uses: 'google-github-actions/deploy-cloud-functions@v4'
428428
timeout-minutes: 10
429429
with:
430430
name: 'my-function'

action.yml

Lines changed: 18 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,9 @@ inputs:
124124
Runtime for the function, such as "nodejs20". For a list of all available
125125
runtimes, run:
126126
127-
$ gcloud functions runtimes list
127+
```sh
128+
$ gcloud functions runtimes list
129+
```
128130
129131
The available runtimes change over time.
130132
required: true
@@ -163,10 +165,10 @@ inputs:
163165
Name of the Cloud Build Custom Worker Pool that should be used to build
164166
the function. The format of this field is:
165167
166-
projects/<project>/locations/<region>/workerPools/<workerPool>
168+
projects/[PROJECT]/locations/[REGION]/workerPools/[WORKER_POOL]
167169
168-
where `<project>` and `<region>` are the project id and region
169-
respectively where the worker pool is defined and `<workerPool>` is the
170+
where `[PROJECT]` and `[REGION]` are the project id and region
171+
respectively where the worker pool is defined and `[WORKER_POOL]` is the
170172
short name of the worker pool.
171173
172174
If the project ID is not the same as the function, then the Cloud
@@ -183,7 +185,7 @@ inputs:
183185
184186
The value must match the pattern:
185187
186-
projects/<project>/locations/<location>/repositories/<repository>.
188+
projects/[PROJECT]/locations/[LOCATION]/repositories/[REPOSITORY].
187189
188190
Cross-project repositories are not supported. Cross-location repositories
189191
are not supported. Repository format must be 'DOCKER'.
@@ -281,7 +283,6 @@ inputs:
281283
volumes. Keys starting with a forward slash '/' are mount paths. All other
282284
keys correspond to environment variables:
283285
284-
285286
```yaml
286287
with:
287288
secrets: |-
@@ -347,11 +348,15 @@ inputs:
347348
Specifies which action should trigger the function. For a list of
348349
acceptable values, run:
349350
350-
$ gcloud functions event-types list
351+
```sh
352+
$ gcloud functions event-types list
353+
```
351354
352355
This usually requires the eventarc API to be enabled:
353356
354-
$ gcloud services enable eventarc.googleapis.com
357+
```sh
358+
$ gcloud services enable eventarc.googleapis.com
359+
```
355360
356361
The available trigger types may change over time.
357362
required: false
@@ -388,7 +393,7 @@ inputs:
388393
will trigger function execution with message contents passed as input
389394
data of the format:
390395
391-
projects/<project_id>/topics/<topic_id>
396+
projects/[PROJECT]/topics/[TOPIC]
392397
393398
The service account must have permissions on this topic.
394399
required: false
@@ -410,7 +415,7 @@ inputs:
410415
description: |-
411416
The name of the channel associated with the trigger in the format:
412417
413-
projects/<project>/locations/<location>/channels/<channel>
418+
projects/[PROJECT]/locations/[LOCATION]/channels/<channel>
414419
415420
You must provide a channel to receive events from Eventarc SaaS partners.
416421
required: false
@@ -421,7 +426,7 @@ outputs:
421426
description: |-
422427
Full resource name of the Cloud Function, of the format:
423428
424-
projects/<project>/locations/<location>/functions/<function>
429+
projects/[PROJECT]/locations/[LOCATION]/functions/<function>
425430
426431
url:
427432
description: |-
@@ -433,5 +438,5 @@ branding:
433438
color: 'blue'
434439

435440
runs:
436-
using: 'node20'
437-
main: 'dist/index.js'
441+
using: 'node24'
442+
main: 'dist/main/index.js'

bin/runTests.sh

Lines changed: 0 additions & 21 deletions
This file was deleted.
File renamed without changes.
File renamed without changes.
File renamed without changes.

0 commit comments

Comments
 (0)