From 5e4bce59bf5c4d164f0d7b9d83889db0bdde13f1 Mon Sep 17 00:00:00 2001 From: Anton Telyshev Date: Thu, 12 Oct 2023 22:54:13 +0300 Subject: [PATCH 1/2] govet: add appends analyzer; update default analyzers; update config reference --- .golangci.reference.yml | 6 ++++-- pkg/golinters/govet.go | 6 +++++- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/.golangci.reference.yml b/.golangci.reference.yml index 511491f60060..6a50682b56d9 100644 --- a/.golangci.reference.yml +++ b/.golangci.reference.yml @@ -1060,8 +1060,9 @@ linters-settings: disable-all: true # Enable analyzers by name (in addition to default). # Run `go tool vet help` to see all analyzers. - # Default: [] + # Default: ["appends", "asmdecl", "assign", "atomic", "bools", "buildtag", "cgocall", "composites", "copylocks", "defers", "directive", "errorsas", "framepointer", "httpresponse", "ifaceassert", "loopclosure", "lostcancel", "nilfunc", "printf", "shift", "sigchanyzer", "slog", "stdmethods", "stringintconv", "structtag", "testinggoroutine", "tests", "timeformat", "unmarshal", "unreachable", "unsafeptr", "unusedresult"] enable: + - appends - asmdecl - assign - atomic @@ -1107,8 +1108,9 @@ linters-settings: enable-all: true # Disable analyzers by name. # Run `go tool vet help` to see all analyzers. - # Default: [] + # Default: ["atomicalign", "deepequalerrors", "fieldalignment", "findcall", "nilness", "reflectvaluecompare", "shadow", "sortslice", "timeformat", "unusedwrite"] disable: + - appends - asmdecl - assign - atomic diff --git a/pkg/golinters/govet.go b/pkg/golinters/govet.go index 5a1309cd01fd..1afa75787906 100644 --- a/pkg/golinters/govet.go +++ b/pkg/golinters/govet.go @@ -2,6 +2,7 @@ package golinters import ( "golang.org/x/tools/go/analysis" + "golang.org/x/tools/go/analysis/passes/appends" "golang.org/x/tools/go/analysis/passes/asmdecl" "golang.org/x/tools/go/analysis/passes/assign" "golang.org/x/tools/go/analysis/passes/atomic" @@ -53,6 +54,7 @@ import ( var ( allAnalyzers = []*analysis.Analyzer{ + appends.Analyzer, asmdecl.Analyzer, assign.Analyzer, atomic.Analyzer, @@ -95,8 +97,9 @@ var ( unusedwrite.Analyzer, } - // https://github.com/golang/go/blob/c19c4c566c63818dfd059b352e52c4710eecf14d/src/cmd/vet/main.go#L47-L78 + // https://github.com/golang/go/blob/b56645a87b28840a180d64077877cb46570b4176/src/cmd/vet/main.go#L49 defaultAnalyzers = []*analysis.Analyzer{ + appends.Analyzer, asmdecl.Analyzer, assign.Analyzer, atomic.Analyzer, @@ -105,6 +108,7 @@ var ( cgocall.Analyzer, composite.Analyzer, copylock.Analyzer, + defers.Analyzer, directive.Analyzer, errorsas.Analyzer, framepointer.Analyzer, From 502544e90c9688cd5f9c5dd88e5afa6a01b28bc2 Mon Sep 17 00:00:00 2001 From: Fernandez Ludovic Date: Thu, 12 Oct 2023 23:57:40 +0200 Subject: [PATCH 2/2] review --- .golangci.reference.yml | 4 ++-- pkg/golinters/govet.go | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.golangci.reference.yml b/.golangci.reference.yml index 6a50682b56d9..f861c41b8aab 100644 --- a/.golangci.reference.yml +++ b/.golangci.reference.yml @@ -1060,7 +1060,7 @@ linters-settings: disable-all: true # Enable analyzers by name (in addition to default). # Run `go tool vet help` to see all analyzers. - # Default: ["appends", "asmdecl", "assign", "atomic", "bools", "buildtag", "cgocall", "composites", "copylocks", "defers", "directive", "errorsas", "framepointer", "httpresponse", "ifaceassert", "loopclosure", "lostcancel", "nilfunc", "printf", "shift", "sigchanyzer", "slog", "stdmethods", "stringintconv", "structtag", "testinggoroutine", "tests", "timeformat", "unmarshal", "unreachable", "unsafeptr", "unusedresult"] + # Default: [] enable: - appends - asmdecl @@ -1108,7 +1108,7 @@ linters-settings: enable-all: true # Disable analyzers by name. # Run `go tool vet help` to see all analyzers. - # Default: ["atomicalign", "deepequalerrors", "fieldalignment", "findcall", "nilness", "reflectvaluecompare", "shadow", "sortslice", "timeformat", "unusedwrite"] + # Default: [] disable: - appends - asmdecl diff --git a/pkg/golinters/govet.go b/pkg/golinters/govet.go index 1afa75787906..4e16fb1429cd 100644 --- a/pkg/golinters/govet.go +++ b/pkg/golinters/govet.go @@ -97,7 +97,7 @@ var ( unusedwrite.Analyzer, } - // https://github.com/golang/go/blob/b56645a87b28840a180d64077877cb46570b4176/src/cmd/vet/main.go#L49 + // https://github.com/golang/go/blob/b56645a87b28840a180d64077877cb46570b4176/src/cmd/vet/main.go#L49-L81 defaultAnalyzers = []*analysis.Analyzer{ appends.Analyzer, asmdecl.Analyzer,