Skip to content

Commit 13b6954

Browse files
committed
review
1 parent 0fa95de commit 13b6954

File tree

1 file changed

+9
-7
lines changed

1 file changed

+9
-7
lines changed

pkg/result/processors/fixer.go

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -133,20 +133,22 @@ func (f Fixer) mergeLineIssues(lineNum int, lineIssues []result.Issue, origFileL
133133

134134
// check issues first
135135
for ind := range lineIssues {
136-
i := &lineIssues[ind]
137-
if i.LineRange != nil {
136+
li := &lineIssues[ind]
137+
138+
if li.LineRange != nil {
138139
f.log.Infof("Line %d has multiple issues but at least one of them is ranged: %#v", lineNum, lineIssues)
139140
return &lineIssues[0]
140141
}
141142

142-
r := i.Replacement
143-
if r.Inline == nil || len(r.NewLines) != 0 || r.NeedOnlyDelete {
143+
inline := li.Replacement.Inline
144+
145+
if inline == nil || len(li.Replacement.NewLines) != 0 || li.Replacement.NeedOnlyDelete {
144146
f.log.Infof("Line %d has multiple issues but at least one of them isn't inline: %#v", lineNum, lineIssues)
145-
return i
147+
return li
146148
}
147149

148-
if r.Inline.StartCol < 0 || r.Inline.Length <= 0 || r.Inline.StartCol+r.Inline.Length > len(origLine) {
149-
f.log.Warnf("Line %d (%q) has invalid inline fix: %#v, %#v", lineNum, origLine, i, r.Inline)
150+
if inline.StartCol < 0 || inline.Length <= 0 || inline.StartCol+inline.Length > len(origLine) {
151+
f.log.Warnf("Line %d (%q) has invalid inline fix: %#v, %#v", lineNum, origLine, li, inline)
150152
return nil
151153
}
152154
}

0 commit comments

Comments
 (0)