Cleanup popup closing code (#150)

darkred · web-flow · commit dd00450cb9e3 · 2024-08-07T03:24:33.000+07:00
diff --git a/source/github-notifications-preview.jsx b/source/github-notifications-preview.jsx
@@ -84,7 +84,7 @@ function createNotificationsDropdown() {
 		// https://github.com/tanmayrajani/notifications-preview-github/issues/50
 		const onClick = event => {
 			if (!event.metaKey && !event.ctrlKey && !event.shiftKey && event.target.closest('a[href]')) {
-				$('.modal-backdrop').click();
+				closeDropdown();
 			}
 		};
 
@@ -181,7 +181,7 @@ async function openDropdown({currentTarget: indicator}) {
 }
 
 function closeDropdown() {
-	$('.NPG-container[open]').removeAttribute('open');
+	$('details.NPG-container[open] > summary').click();
 }
 
 // When the dropdown is open, GitHub's modal blocks all links outside the dropdown.

Original file line number	Diff line number	Diff line change
`@@ -84,7 +84,7 @@ function createNotificationsDropdown() {`
`84`	`84`	`// https://github.com/tanmayrajani/notifications-preview-github/issues/50`
`85`	`85`	`const onClick = event => {`
`86`	`86`	`if (!event.metaKey && !event.ctrlKey && !event.shiftKey && event.target.closest('a[href]')) {`
`87`		`- $('.modal-backdrop').click();`
	`87`	`+ closeDropdown();`
`88`	`88`	`}`
`89`	`89`	`};`
`90`	`90`
`@@ -181,7 +181,7 @@ async function openDropdown({currentTarget: indicator}) {`
`181`	`181`	`}`
`182`	`182`
`183`	`183`	`function closeDropdown() {`
`184`		`- $('.NPG-container[open]').removeAttribute('open');`
	`184`	`+ $('details.NPG-container[open] > summary').click();`
`185`	`185`	`}`
`186`	`186`
`187`	`187`	`// When the dropdown is open, GitHub's modal blocks all links outside the dropdown.`