Skip to content

Commit b617ad7

Browse files
author
Evsyukov Denis
committed
fix: remove unnecessary comments in ResourcesMonitor for cleaner code
Signed-off-by: Evsyukov Denis <[email protected]>
1 parent 92900ed commit b617ad7

File tree

2 files changed

+0
-7
lines changed

2 files changed

+0
-7
lines changed

pkg/helm/post_renderer/post_renderer.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
// Package post_renderer provides a Helm post-renderer for adding extra labels to manifests.
21
package post_renderer
32

43
import (
@@ -9,19 +8,16 @@ import (
98
"sigs.k8s.io/kustomize/kyaml/kio"
109
)
1110

12-
// PostRenderer adds extra labels to rendered Kubernetes manifests.
1311
type PostRenderer struct {
1412
extraLabels map[string]string
1513
}
1614

17-
// NewPostRenderer creates a new PostRenderer with the given extra labels.
1815
func NewPostRenderer(extraLabels map[string]string) *PostRenderer {
1916
return &PostRenderer{
2017
extraLabels: extraLabels,
2118
}
2219
}
2320

24-
// Run adds extra labels to all resources in the rendered manifests.
2521
func (p *PostRenderer) Run(renderedManifests *bytes.Buffer) (*bytes.Buffer, error) {
2622
if len(p.extraLabels) == 0 {
2723
return renderedManifests, nil

pkg/helm_resources_manager/resources_monitor.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,6 @@ func (r *ResourcesMonitor) Start() {
104104
status, err := r.GetHelmReleaseStatus(r.moduleName)
105105
if err != nil {
106106
r.logger.Error("cannot get helm release status", log.Err(err))
107-
continue // Do not proceed if status cannot be obtained
108107
}
109108

110109
if status != "deployed" {
@@ -114,14 +113,12 @@ func (r *ResourcesMonitor) Start() {
114113
if r.absentCb != nil {
115114
r.absentCb(r.moduleName, true, []manifest.Manifest{}, r.defaultNamespace)
116115
}
117-
continue // Do not check resources if status is not deployed
118116
}
119117

120118
// Check resources
121119
absent, err := r.AbsentResources()
122120
if err != nil {
123121
r.logger.Error("cannot list helm resources", log.Err(err))
124-
continue // Do not proceed if resources cannot be listed
125122
}
126123

127124
if len(absent) > 0 {

0 commit comments

Comments
 (0)