feat: enable configuration of the junit results sidecar image

Author: LarsFronius

checks/junit.go

@@ -10,6 +10,7 @@ import (
 
 	"github.com/flanksource/canary-checker/api/context"
 	dutyKubernetes "github.com/flanksource/duty/kubernetes"
+	"github.com/spf13/pflag"
 
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 
@@ -26,11 +27,38 @@ func init() {
 	//register metrics here
 }
 
+// type alias to implement pflag.Value to allow setting in root.go
+type CorePullPolicy corev1.PullPolicy
+
+var _ pflag.Value = (*CorePullPolicy)(nil)
+var AllowedCorePullPolicyValues = []corev1.PullPolicy{corev1.PullAlways, corev1.PullIfNotPresent, corev1.PullNever}
+
+func (c *CorePullPolicy) Set(s string) error {
+	for _, allowed := range AllowedCorePullPolicyValues {
+		if s == string(allowed) {
+			*c = CorePullPolicy(s)
+			return nil
+		}
+	}
+
+	return fmt.Errorf("PullPolicy '%s' not one of allowed values: %v", s, AllowedCorePullPolicyValues)
+}
+
+func (c *CorePullPolicy) String() string {
+	return string(*c)
+}
+
+func (c *CorePullPolicy) Type() string {
+	return "CorePullPolicy"
+}
+
+var JunitContainerImageName string
+var JunitContainerImagePullPolicy CorePullPolicy = CorePullPolicy(corev1.PullIfNotPresent)
+
 const (
 	volumeName           = "junit-results"
 	mountPath            = "/tmp/junit-results"
 	containerName        = "junit-results"
-	containerImage       = "ubuntu"
 	podKind              = "Pod"
 	junitCheckSelector   = "canary-checker.flanksource.com/check"
 	junitCheckLabelValue = "junit-check"
@@ -83,8 +111,9 @@ func newPod(ctx *context.Context, check v1.JunitCheck) (*corev1.Pod, error) {
 	}
 	pod.Spec.Containers = []corev1.Container{
 		{
-			Name:  containerName,
-			Image: containerImage,
+			Name:            containerName,
+			ImagePullPolicy: corev1.PullPolicy(JunitContainerImagePullPolicy),
+			Image:           JunitContainerImageName,
 			Args: []string{
 				"bash",
 				"-c",

cmd/root.go

@@ -230,6 +230,17 @@ func ServerFlags(flags *pflag.FlagSet) {
 		os.Getenv("UPSTREAM_INSECURE_SKIP_VERIFY") == "true",
 		"Skip TLS verification on the upstream servers certificate",
 	)
+	flags.StringVar(
+		&checks.JunitContainerImageName,
+		"junit-results-container-image-name",
+		"ubuntu:latest",
+		"Sets the container image name for the junit results container sidecar",
+	)
+	flags.Var(
+		&checks.JunitContainerImagePullPolicy,
+		"junit-results-container-image-pull-policy",
+		fmt.Sprintf("Sets the junit results container sidecar pull policy. Allowed values: %v", checks.AllowedCorePullPolicyValues),
+	)
 
 	duty.BindPFlags(flags, duty.SkipMigrationByDefaultMode)