Skip to content

Commit 59d6bf9

Browse files
jorge-cabjorge-cab
committed
[Compiler] Change ValidateNoDerivedComputationsInEffect logic to track prop and local state derived values variables and add extra tests
Summary: Biggest change of the stack, we track how values prop and local state values are derived throughout the entire component. This PR also adds a couple tests we will work towards fixing Test Plan: Added: ref-conditional-in-effect-no-error effect-contains-prop-function-call-no-error derived-state-from-ref-and-state-no-error
1 parent 5b75fc9 commit 59d6bf9

File tree

28 files changed

+638
-845
lines changed

28 files changed

+638
-845
lines changed

‎compiler/packages/babel-plugin-react-compiler/src/Validation/ValidateNoDerivedComputationsInEffects.ts‎

Lines changed: 228 additions & 141 deletions
Large diffs are not rendered by default.

‎compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/effect-derived-computations/derived-state-conditionally-in-effect.expect.md‎

Lines changed: 0 additions & 79 deletions
This file was deleted.

‎compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/effect-derived-computations/derived-state-from-default-props.expect.md‎

Lines changed: 0 additions & 71 deletions
This file was deleted.

‎compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/effect-derived-computations/derived-state-from-local-state-in-effect.expect.md‎

Lines changed: 0 additions & 70 deletions
This file was deleted.

‎compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/effect-derived-computations/derived-state-from-prop-local-state-and-component-scope.expect.md‎

Lines changed: 0 additions & 108 deletions
This file was deleted.

0 commit comments

Comments
 (0)