Pass -Wno-character-conversion to gtest build (#24350)

dschuff · web-flow · commit 87fb56e8a088 · 2025-05-16T10:23:01.000-07:00
llvm/llvm-project#138708 added a new warning for converting different charN_t types, which triggers in the googletest build. Disable this warning until it's fixed upstream.
diff --git a/test/test_other.py b/test/test_other.py
@@ -15036,7 +15036,7 @@ def test_googletest(self):
       test_file('third_party/googletest/googletest/src/gtest-all.cc'),
       test_file('third_party/googletest/googletest/src/gtest_main.cc'),
     ]
-    self.do_other_test('test_googletest.cc')
+    self.do_other_test('test_googletest.cc', emcc_args=['-Wno-character-conversion', '-Wno-unknown-warning-option'])
 
   def test_parseTools_legacy(self):
     create_file('post.js', '''

Original file line number	Diff line number	Diff line change
`@@ -15036,7 +15036,7 @@ def test_googletest(self):`
`15036`	`15036`	`test_file('third_party/googletest/googletest/src/gtest-all.cc'),`
`15037`	`15037`	`test_file('third_party/googletest/googletest/src/gtest_main.cc'),`
`15038`	`15038`	`]`
`15039`		`- self.do_other_test('test_googletest.cc')`
	`15039`	`+ self.do_other_test('test_googletest.cc', emcc_args=['-Wno-character-conversion', '-Wno-unknown-warning-option'])`
`15040`	`15040`
`15041`	`15041`	`def test_parseTools_legacy(self):`
`15042`	`15042`	`create_file('post.js', '''`