Skip to content

Commit e0eea1f

Browse files
authored
Disable certain stackoverflow tests (#116535)
1 parent e82789b commit e0eea1f

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

src/tests/baseservices/exceptions/stackoverflow/stackoverflowtester.cs

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -185,15 +185,16 @@ public static void TestStackOverflowSmallFrameSecondaryThread()
185185
[Fact]
186186
public static void TestStackOverflowLargeFrameSecondaryThread()
187187
{
188-
if (((RuntimeInformation.ProcessArchitecture == Architecture.Arm64) || (RuntimeInformation.ProcessArchitecture == Architecture.RiscV64) ||
189-
(RuntimeInformation.ProcessArchitecture == Architecture.LoongArch64)) &&
188+
if (((RuntimeInformation.ProcessArchitecture == Architecture.Arm64) || (RuntimeInformation.ProcessArchitecture == Architecture.X64) || (RuntimeInformation.ProcessArchitecture == Architecture.RiscV64) ||
189+
(RuntimeInformation.ProcessArchitecture == Architecture.LoongArch64) || (RuntimeInformation.ProcessArchitecture == Architecture.Arm)) &&
190190
((Environment.OSVersion.Platform == PlatformID.Unix) || (Environment.OSVersion.Platform == PlatformID.MacOSX)))
191191
{
192192
// Disabled on Unix RISCV64 and LoongArch64, similar to ARM64.
193193
// LoongArch64 hit this issue on Alpine. TODO: implement stack probing using helpers.
194194
// Disabled on Unix ARM64 due to https://github.com/dotnet/runtime/issues/13519
195195
// The current stack probing doesn't move the stack pointer and so the runtime sometimes cannot
196196
// recognize the underlying sigsegv as stack overflow when it probes too far from SP.
197+
// Disabled on Unix X64/Arm due to https://github.com/dotnet/runtime/issues/110173 which needs investigation.
197198
return;
198199
}
199200

@@ -223,9 +224,10 @@ public static void TestStackOverflowLargeFrameSecondaryThread()
223224
[Fact]
224225
public static void TestStackOverflow3()
225226
{
226-
if (RuntimeInformation.ProcessArchitecture == Architecture.Arm)
227+
if ((RuntimeInformation.ProcessArchitecture == Architecture.Arm) || ((RuntimeInformation.ProcessArchitecture == Architecture.Arm64) && (Environment.OSVersion.Platform == PlatformID.Unix)))
227228
{
228229
// Disabled on ARM due to https://github.com/dotnet/runtime/issues/107184
230+
// Disabled on Unix ARM64 due to https://github.com/dotnet/runtime/issues/110173 which needs investigation.
229231
return;
230232
}
231233

0 commit comments

Comments
 (0)