Update diagnostic IDs to ASPDEPR008/ASPDEPR004, remove unnecessary pragma disables, and add suppression to test projects

Co-authored-by: BrennanConroy <[email protected]>

Author: Copilot

src/Hosting/Hosting/src/WebHostExtensions.cs

@@ -12,7 +12,7 @@ namespace Microsoft.AspNetCore.Hosting;
 /// <summary>
 /// Contains extensions for managing the lifecycle of an <see cref="IWebHost"/>.
 /// </summary>
-[Obsolete("WebHostExtensions is obsolete. Use Host.CreateDefaultBuilder or WebApplication.CreateBuilder instead.")]
+[Obsolete("WebHostExtensions is obsolete. Use Host.CreateDefaultBuilder or WebApplication.CreateBuilder instead.", DiagnosticId = "ASPDEPR008")]
 public static class WebHostExtensions
 {
     /// <summary>

src/Hosting/Hosting/test/WebHostTests.cs

@@ -1087,9 +1087,7 @@ public void ConfigureServices(IServiceCollection services, int gunk) { }
         public void Configure(IApplicationBuilder app) { }
     }
 
-#pragma warning disable CS0618 // Type or member is obsolete
     private IWebHost CreateHost(RequestDelegate requestDelegate)
-#pragma warning restore CS0618 // Type or member is obsolete
     {
         var builder = CreateBuilder()
             .UseFakeServer()

src/Hosting/TestHost/src/TestServer.cs

@@ -80,7 +80,7 @@ public TestServer(IServiceProvider services, IFeatureCollection featureCollectio
     /// For use with IWebHostBuilder.
     /// </summary>
     /// <param name="builder"></param>
-    [Obsolete("IWebHost, which this method uses, is obsolete. Use one of the ctors that takes an IServiceProvider instead.")]
+    [Obsolete("IWebHost, which this method uses, is obsolete. Use one of the ctors that takes an IServiceProvider instead.", DiagnosticId = "ASPDEPR008")]
     public TestServer(IWebHostBuilder builder)
         : this(builder, CreateTestFeatureCollection())
     {
@@ -91,7 +91,7 @@ public TestServer(IWebHostBuilder builder)
     /// </summary>
     /// <param name="builder"></param>
     /// <param name="featureCollection"></param>
-    [Obsolete("IWebHost, which this method uses, is obsolete. Use one of the ctors that takes an IServiceProvider instead.")]
+    [Obsolete("IWebHost, which this method uses, is obsolete. Use one of the ctors that takes an IServiceProvider instead.", DiagnosticId = "ASPDEPR008")]
     public TestServer(IWebHostBuilder builder, IFeatureCollection featureCollection)
     {
         ArgumentNullException.ThrowIfNull(builder);
@@ -113,7 +113,7 @@ public TestServer(IWebHostBuilder builder, IFeatureCollection featureCollection)
     /// <summary>
     /// Gets the <see cref="IWebHost" /> instance associated with the test server.
     /// </summary>
-    [Obsolete("IWebHost is obsolete. Use IHost instead.")]
+    [Obsolete("IWebHost is obsolete. Use IHost instead.", DiagnosticId = "ASPDEPR008")]
     public IWebHost Host
     {
         get

src/Hosting/TestHost/src/WebHostBuilderExtensions.cs

@@ -51,7 +51,7 @@ public static IWebHostBuilder UseTestServer(this IWebHostBuilder builder, Action
     /// </summary>
     /// <param name="host"></param>
     /// <returns></returns>
-    [Obsolete("IWebHost is obsolete. Use IHost instead.")]
+    [Obsolete("IWebHost is obsolete. Use IHost instead.", DiagnosticId = "ASPDEPR008")]
     public static TestServer GetTestServer(this IWebHost host)
     {
         return (TestServer)host.Services.GetRequiredService<IServer>();
@@ -62,7 +62,7 @@ public static TestServer GetTestServer(this IWebHost host)
     /// </summary>
     /// <param name="host"></param>
     /// <returns></returns>
-    [Obsolete("IWebHost is obsolete. Use IHost instead.")]
+    [Obsolete("IWebHost is obsolete. Use IHost instead.", DiagnosticId = "ASPDEPR008")]
     public static HttpClient GetTestClient(this IWebHost host)
     {
         return host.GetTestServer().CreateClient();

src/Hosting/TestHost/test/ClientHandlerTests.cs

@@ -1,8 +1,6 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
-#pragma warning disable CS0618 // Type or member is obsolete
-
 using System.Net;
 using System.Net.Http;
 using System.Text;

src/Hosting/TestHost/test/HttpContextBuilderTests.cs

@@ -1,8 +1,6 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
-#pragma warning disable CS0618 // Type or member is obsolete
-
 using System.Text;
 using Microsoft.AspNetCore.Builder;
 using Microsoft.AspNetCore.Hosting;

src/Hosting/TestHost/test/Microsoft.AspNetCore.TestHost.Tests.csproj

@@ -2,6 +2,7 @@
 
   <PropertyGroup>
     <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework>
+    <NoWarn>$(NoWarn);ASPDEPR008</NoWarn>
   </PropertyGroup>
 
   <ItemGroup>

src/Hosting/TestHost/test/TestClientTests.cs

@@ -1,8 +1,6 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
-#pragma warning disable CS0618 // Type or member is obsolete
-
 using System.Net;
 using System.Net.Http;
 using System.Net.WebSockets;

src/Hosting/WindowsServices/src/WebHostService.cs

@@ -12,7 +12,7 @@ namespace Microsoft.AspNetCore.Hosting.WindowsServices;
 ///     Provides an implementation of a Windows service that hosts ASP.NET Core.
 /// </summary>
 [DesignerCategory("Code")]
-[Obsolete("Use UseWindowsService and AddHostedService instead.")]
+[Obsolete("Use UseWindowsService and AddHostedService instead.", DiagnosticId = "ASPDEPR004")]
 public class WebHostService : ServiceBase
 {
     private readonly IWebHost _host;

src/Hosting/WindowsServices/src/WebHostWindowsServiceExtensions.cs

@@ -8,7 +8,7 @@ namespace Microsoft.AspNetCore.Hosting.WindowsServices;
 /// <summary>
 ///     Extensions to <see cref="IWebHost"/> for hosting inside a Windows service.
 /// </summary>
-[Obsolete("Use UseWindowsService and AddHostedService instead.")]
+[Obsolete("Use UseWindowsService and AddHostedService instead.", DiagnosticId = "ASPDEPR004")]
 public static class WebHostWindowsServiceExtensions
 {
     /// <summary>