Application package reporter continued

Author: grendello

tools/apput/src/Android/AndroidManifest.cs

@@ -7,14 +7,18 @@ namespace ApplicationUtility;
 public class AndroidManifest : IAspect
 {
 	public string Description { get; }
+	public string? PackageName { get; }
 
-	AXMLParser? binaryParser;
 	XmlDocument? xmlDoc;
+	XmlNamespaceManager? nsmgr;
 
 	AndroidManifest (AXMLParser binaryParser, string? description)
 	{
 		Description = String.IsNullOrEmpty (description) ? "Android manifest" : description;
-		this.binaryParser = binaryParser;
+		Read (binaryParser);
+
+		nsmgr = PrepareForReading (xmlDoc);
+		PackageName = TryGetPackageName (xmlDoc, nsmgr);
 	}
 
 	public static IAspect LoadAspect (Stream stream, IAspectState state, string? description)
@@ -30,7 +34,6 @@ public static IAspect LoadAspect (Stream stream, IAspectState state, string? des
 		} else {
 			throw new NotImplementedException ();
 		}
-		ret.Read ();
 
 		return ret;
 	}
@@ -62,7 +65,7 @@ public static IAspectState ProbeAspect (Stream stream, string? description)
 		return new BasicAspectState (success: false);
 	}
 
-	void Read ()
+	void Read (AXMLParser? binaryParser)
 	{
 		if (binaryParser == null) {
 			throw new NotImplementedException ();
@@ -76,6 +79,131 @@ void Read ()
 		Log.Debug ($"'{Description}' loaded and parsed correctly.");
 	}
 
+	static XmlNamespaceManager? PrepareForReading (XmlDocument? doc)
+	{
+		if (doc == null) {
+			return null;
+		}
+
+		var nsmgr = new XmlNamespaceManager (doc.NameTable);
+		nsmgr.AddNamespace ("android", "http://schemas.android.com/apk/res/android");
+		return nsmgr;
+	}
+
+	static bool ValidXmlContext (XmlDocument? doc, XmlNamespaceManager? nsmgr, out XmlElement? root)
+	{
+		root = null;
+		if (doc == null || nsmgr == null) {
+			return false;
+		}
+
+		root = doc.DocumentElement;
+		return root != null;
+	}
+
+	static string? TryGetMainActivity (XmlDocument? doc, XmlNamespaceManager? nsmgr)
+	{
+		if (!ValidXmlContext (doc, nsmgr, out XmlElement? root)) {
+			return null;
+		}
+
+		XmlNodeList? activities = root!.SelectNodes ("//manifest/application/activity", nsmgr!);
+		if (activities == null || activities.Count == 0) {
+			return null;
+		}
+
+		foreach (XmlNode activity in activities) {
+			string? name = GetLauncherActivityName (activity);
+			if (name == null) {
+				continue;
+			}
+
+			return name;
+		}
+
+		return null;
+
+		string? GetLauncherActivityName (XmlNode activity)
+		{
+			XmlNodeList? intentFilters = activity.SelectNodes ("./intent-filter", nsmgr!);
+			if (intentFilters == null || intentFilters.Count == 0) {
+				return null;
+			}
+
+			bool isMain = false;
+			foreach (XmlNode intentFilter in intentFilters) {
+				XmlNodeList? actions = activity.SelectNodes ("./action", nsmgr!);
+				if (actions == null || actions.Count == 0) {
+					continue;
+				}
+
+				if (!HaveNodeWithNameAttribute (actions, "android.intent.action.MAIN")) {
+					continue;
+				}
+
+				XmlNodeList? categories = activity.SelectNodes ("./category", nsmgr!);
+				if (categories == null || categories.Count == 0) {
+					continue;
+				}
+
+				if (!HaveNodeWithNameAttribute (categories, "android.intent.category.LAUNCHER")) {
+					continue;
+				}
+
+				isMain = true;
+				break;
+			}
+
+			if (!isMain) {
+				return null;
+			}
+
+			var attr = activity.Attributes?.GetNamedItem ("android:name");
+			if (attr == null) {
+				return null;
+			}
+
+			return attr.Value;
+		}
+
+		bool HaveNodeWithNameAttribute (XmlNodeList list, string nameValue)
+		{
+			foreach (XmlNode? node in list) {
+				var attr = node?.Attributes?.GetNamedItem ("android:name");
+				if (attr == null || String.IsNullOrEmpty (attr.Value)) {
+					continue;
+				}
+
+				if (attr.Value == nameValue) {
+					return true;
+				}
+			}
+
+			return false;
+		}
+	}
+
+	static string? TryGetPackageName (XmlDocument? doc, XmlNamespaceManager? nsmgr)
+	{
+		Log.Debug ("Trying to read package name");
+		if (!ValidXmlContext (doc, nsmgr, out XmlElement? root) || root == null) {
+			return null;
+		}
+
+		XmlNode? manifest = root.SelectSingleNode ("//manifest", nsmgr);
+		if (manifest == null || manifest.Attributes == null) {
+			Log.Debug ("`manifest` element not found or it has no attributes");
+			return null;
+		}
+
+		XmlNode? package = manifest.Attributes.GetNamedItem ("package");
+		if (package == null) {
+			Log.Debug ("`package` attribute in the `manifest` element not found");
+		}
+
+		return package == null ? null : package.Value;
+	}
+
 	static XmlDocument ParsePlainXML (Stream stream)
 	{
 		stream.Seek (0, SeekOrigin.Begin);

tools/apput/src/Package/ApplicationPackage.cs

@@ -312,6 +312,7 @@ void TryLoadAndroidManifest ()
 				return;
 			}
 			manifest = (AndroidManifest)AndroidManifest.LoadAspect (manifestStream, manifestState, AndroidManifestPath);
+			PackageName = manifest.PackageName ?? String.Empty;
 		} catch (Exception ex) {
 			Log.Debug ($"Failed to load android manifest '{AndroidManifestPath}' from the archive.", ex);
 		}

tools/apput/src/Reporters/ApplicationPackageReporter.cs

@@ -17,6 +17,17 @@ public ApplicationPackageReporter (ApplicationPackage package)
 
 	protected override void DoReport ()
 	{
-		throw new System.NotImplementedException ();
+		WriteAspectDesc (package.PackageFormat);
+
+		WriteSubsectionBanner ("Generic Android application information");
+		WriteNativeArch (package.Architectures);
+		WriteItem ("Package name", ValueOrNone (package.PackageName));
+		WriteItem ("Main activity", ValueOrNone (package.MainActivity));
+		WriteYesNo ("Valid Android package", package.ValidAndroidPackage);
+		WriteYesNo ("Signed", package.Signed);
+		WriteYesNo ("Debuggable", package.Debuggable);
+
+		WriteSubsectionBanner (".NET for Android application information");
+		WriteItem ("Runtime", package.Runtime.ToString ());
 	}
 }

tools/apput/src/Reporters/BaseReporter.cs

@@ -1,10 +1,17 @@
 using System;
+using System.Collections.Generic;
+using System.Linq;
+
+using Xamarin.Android.Tools;
 
 namespace ApplicationUtility;
 
 abstract class BaseReporter : IReporter
 {
-	protected const ConsoleColor LabelColor = ConsoleColor.White;
+	const string NativeArchitectureLabel = "Native target architecture";
+	const string NativeArchitecturesLabel = NativeArchitectureLabel + "s";
+
+	protected const ConsoleColor LabelColor = ConsoleColor.Gray;
 	protected const ConsoleColor ValidValueColor = ConsoleColor.Green;
 	protected const ConsoleColor InvalidValueColor = ConsoleColor.Red;
 	protected const ConsoleColor BannerColor = ConsoleColor.Cyan;
@@ -21,16 +28,50 @@ public void Report ()
 
 	protected abstract void DoReport ();
 
+	protected void WriteSubsectionBanner (string text)
+	{
+		WriteLine ();
+		WriteLine (BannerColor, $"## {text}");
+	}
+
 	protected void WriteAspectDesc (string text)
 	{
 		WriteItem ("Aspect type", text);
 	}
 
 	protected void WriteNativeArch (NativeArchitecture arch)
 	{
-		WriteItem ("Native target architecture", arch.ToString ());
+		WriteItem (NativeArchitectureLabel, arch.ToString ());
 	}
 
+	protected void WriteNativeArch (AndroidTargetArch arch)
+	{
+		WriteItem (NativeArchitectureLabel, arch.ToString ());
+	}
+
+	protected void WriteNativeArch (ICollection<AndroidTargetArch> arches)
+	{
+		if (arches.Count == 1) {
+			WriteNativeArch (arches.First ());
+			return;
+		}
+
+		WriteLabel (NativeArchitecturesLabel);
+		if (arches.Count == 0) {
+			WriteLine (InvalidValueColor, "none");
+			return;
+		}
+
+		var architectures = new List<string> ();
+		foreach (AndroidTargetArch arch in arches) {
+			architectures.Add (arch.ToString ());
+		}
+
+		WriteLine (ValidValueColor, String.Join (", ", architectures));
+	}
+
+	protected void WriteYesNo (string label, bool value) => WriteItem (label, YesNo (value));
+
 	protected void WriteLabel (string label)
 	{
 		Write (LabelColor, $"{label}: ");