Skip to content

Commit 38c06f7

Browse files
committed
[DevTools] Only check if we previously removed IO if its removal failed (facebook#34506)
DiffTrain build for [a51f925](facebook@a51f925)
1 parent ba52fbb commit 38c06f7

35 files changed

+2376
-3916
lines changed

compiled/eslint-plugin-react-hooks/index.js

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -25489,10 +25489,6 @@ function isReorderableExpression(builder, expr, allowLocalIdentifiers) {
2548925489
return true;
2549025490
}
2549125491
}
25492-
case 'TSInstantiationExpression': {
25493-
const innerExpr = expr.get('expression');
25494-
return isReorderableExpression(builder, innerExpr, allowLocalIdentifiers);
25495-
}
2549625492
case 'RegExpLiteral':
2549725493
case 'StringLiteral':
2549825494
case 'NumericLiteral':
@@ -32159,7 +32155,6 @@ const EnvironmentConfigSchema = zod.z.object({
3215932155
enableCustomTypeDefinitionForReanimated: zod.z.boolean().default(false),
3216032156
hookPattern: zod.z.string().nullable().default(null),
3216132157
enableTreatRefLikeIdentifiersAsRefs: zod.z.boolean().default(true),
32162-
enableTreatSetIdentifiersAsStateSetters: zod.z.boolean().default(false),
3216332158
lowerContextAccess: ExternalFunctionSchema.nullable().default(null),
3216432159
validateNoVoidUseMemo: zod.z.boolean().default(false),
3216532160
validateNoDynamicallyCreatedComponentsOrHooks: zod.z.boolean().default(false),
@@ -41670,9 +41665,7 @@ function computeSignatureForInstruction(context, env, instr) {
4167041665
}
4167141666
case 'PropertyStore':
4167241667
case 'ComputedStore': {
41673-
const mutationReason = value.kind === 'PropertyStore' &&
41674-
value.property === 'current' &&
41675-
value.object.identifier.type.kind === 'Type'
41668+
const mutationReason = value.kind === 'PropertyStore' && value.property === 'current'
4167641669
? { kind: 'AssignCurrentProperty' }
4167741670
: null;
4167841671
effects.push({
@@ -48015,16 +48008,9 @@ function* generateInstructionTypes(env, names, instr) {
4801548008
}
4801648009
case 'CallExpression': {
4801748010
const returnType = makeType();
48018-
let shapeId = null;
48019-
if (env.config.enableTreatSetIdentifiersAsStateSetters) {
48020-
const name = getName(names, value.callee.identifier.id);
48021-
if (name.startsWith('set')) {
48022-
shapeId = BuiltInSetStateId;
48023-
}
48024-
}
4802548011
yield equation(value.callee.identifier.type, {
4802648012
kind: 'Function',
48027-
shapeId,
48013+
shapeId: null,
4802848014
return: returnType,
4802948015
isConstructor: false,
4803048016
});

compiled/facebook-www/REVISION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
6eda534718d09a26d58d65c0a376e05d7e2a3358
1+
a51f925217e7c2a92fe4df707487acb29cb12b1e
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
6eda534718d09a26d58d65c0a376e05d7e2a3358
1+
a51f925217e7c2a92fe4df707487acb29cb12b1e

compiled/facebook-www/React-dev.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1419,7 +1419,7 @@ __DEV__ &&
14191419
exports.useTransition = function () {
14201420
return resolveDispatcher().useTransition();
14211421
};
1422-
exports.version = "19.2.0-www-classic-6eda5347-20250918";
1422+
exports.version = "19.2.0-www-classic-a51f9252-20250916";
14231423
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
14241424
"function" ===
14251425
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-dev.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1419,7 +1419,7 @@ __DEV__ &&
14191419
exports.useTransition = function () {
14201420
return resolveDispatcher().useTransition();
14211421
};
1422-
exports.version = "19.2.0-www-modern-6eda5347-20250918";
1422+
exports.version = "19.2.0-www-modern-a51f9252-20250916";
14231423
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
14241424
"function" ===
14251425
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-prod.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -602,4 +602,4 @@ exports.useSyncExternalStore = function (
602602
exports.useTransition = function () {
603603
return ReactSharedInternals.H.useTransition();
604604
};
605-
exports.version = "19.2.0-www-classic-6eda5347-20250918";
605+
exports.version = "19.2.0-www-classic-a51f9252-20250916";

compiled/facebook-www/React-prod.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -602,4 +602,4 @@ exports.useSyncExternalStore = function (
602602
exports.useTransition = function () {
603603
return ReactSharedInternals.H.useTransition();
604604
};
605-
exports.version = "19.2.0-www-modern-6eda5347-20250918";
605+
exports.version = "19.2.0-www-modern-a51f9252-20250916";

compiled/facebook-www/React-profiling.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -606,7 +606,7 @@ exports.useSyncExternalStore = function (
606606
exports.useTransition = function () {
607607
return ReactSharedInternals.H.useTransition();
608608
};
609-
exports.version = "19.2.0-www-classic-6eda5347-20250918";
609+
exports.version = "19.2.0-www-classic-a51f9252-20250916";
610610
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
611611
"function" ===
612612
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-profiling.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -606,7 +606,7 @@ exports.useSyncExternalStore = function (
606606
exports.useTransition = function () {
607607
return ReactSharedInternals.H.useTransition();
608608
};
609-
exports.version = "19.2.0-www-modern-6eda5347-20250918";
609+
exports.version = "19.2.0-www-modern-a51f9252-20250916";
610610
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
611611
"function" ===
612612
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

0 commit comments

Comments
 (0)