Warn the user if they've activated the wrong major-mode #370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clojure-mode.el
Outdated
| (clojure-font-lock-setup) | ||
| (add-hook 'paredit-mode-hook #'clojure-paredit-setup)) | ||
|
|
||
| (defcustom clojure-do-warnings t |
There was a problem hiding this comment.
I'd name this differently - e.g. clojure-verify-major-mode. How do you even do warnings? :-) I'm guessing you meant this to be generic, but I'm not sure that's a good idea.
Malabarba
force-pushed
the
warn-major-mode
branch
from
12b84ce to
8401fde
Compare
clojure-mode.el
Outdated
| 'clojurec-mode)))) | ||
| (when problem | ||
| (message "[WARNING] %s activated `%s' instead of `%s' in this buffer. | ||
| This is could cause problems. |
|
Apart from my small remarks - this needs a changelog entry. Otherwise - good idea! |
Malabarba
force-pushed
the
warn-major-mode
branch
from
8401fde to
7ed634b
Compare
Malabarba
added a commit
that referenced
this pull request
Mar 11, 2016
Warn the user if they've activated the wrong major-mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clojure-emacs/cider#1611