diff --git a/.github/workflows/maven-verify.yml b/.github/workflows/maven-verify.yml index ff3f00c3..1145a39e 100644 --- a/.github/workflows/maven-verify.yml +++ b/.github/workflows/maven-verify.yml @@ -26,6 +26,5 @@ jobs: name: Verify uses: apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v4 with: - ff-maven: "4.0.0-beta-5" # Maven version for fail-fast-build - maven-matrix: '[ "4.0.0-beta-5" ]' - jdk-matrix: '[ "17", "21" ]' + maven4-build: true + maven4-version: '4.0.0-rc-2' # as in project diff --git a/pom.xml b/pom.xml index faffca19..4ec17d2f 100644 --- a/pom.xml +++ b/pom.xml @@ -69,7 +69,7 @@ under the License. 17 - 4.0.0-beta-5 + 4.0.0-rc-2 6.0.0 ${version.maven-antrun-plugin} @@ -83,7 +83,7 @@ under the License. ${version.maven-source-plugin} ${version.maven-surefire} ${version.maven-war-plugin} - 4.0.0-beta-2 + 4.0.0-beta-3 2.0.2 5.15.2 2.0.13 @@ -119,7 +119,7 @@ under the License. org.apache.maven - maven-api-meta + maven-api-annotations ${mavenVersion} provided @@ -151,7 +151,7 @@ under the License. org.apache.maven - maven-api-impl + maven-impl ${mavenVersion} test diff --git a/src/it/deploy-bom/verify.groovy b/src/it/deploy-bom/verify.groovy index 2b314e99..5f865e28 100644 --- a/src/it/deploy-bom/verify.groovy +++ b/src/it/deploy-bom/verify.groovy @@ -18,7 +18,7 @@ */ def expectedDeploys = [ - 'org/apache/maven/its/deploy/bom/test/1.0/test-1.0-build.pom', +// 'org/apache/maven/its/deploy/bom/test/1.0/test-1.0-build.pom', - rc-2 fix 'org/apache/maven/its/deploy/bom/test/1.0/test-1.0.pom', 'org/apache/maven/its/deploy/bom/test/maven-metadata.xml', ] diff --git a/src/main/java/org/apache/maven/plugins/deploy/DeployFileMojo.java b/src/main/java/org/apache/maven/plugins/deploy/DeployFileMojo.java index af5efd56..63c269ec 100644 --- a/src/main/java/org/apache/maven/plugins/deploy/DeployFileMojo.java +++ b/src/main/java/org/apache/maven/plugins/deploy/DeployFileMojo.java @@ -276,7 +276,7 @@ public void execute() throws MojoException { failIfOffline(); warnIfAffectedPackagingAndMaven(packaging); - List deployables = new ArrayList<>(); + List deployables = new ArrayList<>(); boolean isFilePom = classifier == null && "pom".equals(packaging); ProducedArtifact artifact = session.createProducedArtifact( diff --git a/src/main/java/org/apache/maven/plugins/deploy/DeployMojo.java b/src/main/java/org/apache/maven/plugins/deploy/DeployMojo.java index c0831bbd..1cdf590c 100644 --- a/src/main/java/org/apache/maven/plugins/deploy/DeployMojo.java +++ b/src/main/java/org/apache/maven/plugins/deploy/DeployMojo.java @@ -212,7 +212,7 @@ private boolean hasDeployExecution(Project p) { } private void deployAllAtOnce() { - Map>> flattenedRequests = new LinkedHashMap<>(); + Map>> flattenedRequests = new LinkedHashMap<>(); // flatten requests, grouping by remote repository and number of retries for (Project reactorProject : session.getProjects()) { State state = getState(reactorProject); @@ -227,8 +227,9 @@ private void deployAllAtOnce() { } // Re-group all requests List requests = new ArrayList<>(); - for (Map.Entry>> entry1 : flattenedRequests.entrySet()) { - for (Map.Entry> entry2 : entry1.getValue().entrySet()) { + for (Map.Entry>> entry1 : flattenedRequests.entrySet()) { + for (Map.Entry> entry2 : + entry1.getValue().entrySet()) { requests.add(ArtifactDeployerRequest.builder() .session(session) .repository(entry1.getKey()) diff --git a/src/test/java/org/apache/maven/plugins/deploy/DeployMojoPomPackagingTest.java b/src/test/java/org/apache/maven/plugins/deploy/DeployMojoPomPackagingTest.java index 37c67366..9fe0d974 100644 --- a/src/test/java/org/apache/maven/plugins/deploy/DeployMojoPomPackagingTest.java +++ b/src/test/java/org/apache/maven/plugins/deploy/DeployMojoPomPackagingTest.java @@ -25,6 +25,7 @@ import java.util.stream.Collectors; import org.apache.maven.api.Artifact; +import org.apache.maven.api.ProducedArtifact; import org.apache.maven.api.Project; import org.apache.maven.api.di.Inject; import org.apache.maven.api.di.Priority; @@ -87,7 +88,7 @@ public void testBasicDeployWithPackagingAsPom(DeployMojo mojo) throws Exception ArtifactDeployerRequest request = execute(mojo); assertNotNull(request); - Collection artifacts = request.getArtifacts(); + Collection artifacts = request.getArtifacts(); assertEquals( Collections.singletonList("org.apache.maven.test:maven-deploy-test:pom:1.0-SNAPSHOT"), artifacts.stream().map(Artifact::key).collect(Collectors.toList())); diff --git a/src/test/java/org/apache/maven/plugins/deploy/DeployMojoTest.java b/src/test/java/org/apache/maven/plugins/deploy/DeployMojoTest.java index 79e9913a..61c1d10f 100644 --- a/src/test/java/org/apache/maven/plugins/deploy/DeployMojoTest.java +++ b/src/test/java/org/apache/maven/plugins/deploy/DeployMojoTest.java @@ -26,6 +26,7 @@ import java.util.stream.Collectors; import org.apache.maven.api.Artifact; +import org.apache.maven.api.ProducedArtifact; import org.apache.maven.api.Project; import org.apache.maven.api.RemoteRepository; import org.apache.maven.api.di.Inject; @@ -108,7 +109,7 @@ public void testBasicDeploy(DeployMojo mojo) throws Exception { ArtifactDeployerRequest request = execute(mojo); assertNotNull(request); - Collection artifacts = request.getArtifacts(); + Collection artifacts = request.getArtifacts(); assertEquals( Arrays.asList( "org.apache.maven.test:maven-deploy-test:pom:1.0-SNAPSHOT", @@ -167,7 +168,7 @@ public void testDeployWithAttachedArtifacts(DeployMojo mojo) throws Exception { ArtifactDeployerRequest request = execute(mojo); assertNotNull(request); - Collection artifacts = request.getArtifacts(); + Collection artifacts = request.getArtifacts(); assertEquals( Arrays.asList( "org.apache.maven.test:maven-deploy-test:pom:1.0-SNAPSHOT",