Merge pull request #230 from adjust/v4371

Version 4.37.1

Author: uerceg

CHANGELOG.md

@@ -1,3 +1,13 @@
+### Version 4.37.1 (30th January 2024)
+#### Fixed
+- Marked all Android method parameters as `final` to address compilation errors when trying to access a callback inside of the inner class (https://github.com/adjust/react_native_sdk/issues/226).
+
+#### Native SDKs
+- [[email protected]][ios_sdk_v4.37.0]
+- [[email protected]][android_sdk_v4.38.1]
+
+---
+
 ### Version 4.37.0 (30th January 2024)
 #### Added
 - Added ability to process shortened deep links and provide the unshortened link back as a response. You can achieve this by invoking `processDeeplink` method of the `Adjust` instance.

VERSION

@@ -1 +1 @@
-4.37.0
+4.37.1

android/libs/adjust-android.jar

@@ -96,7 +96,7 @@ public boolean launchReceivedDeeplink(Uri uri) {
     }
 
     @ReactMethod
-    public void create(ReadableMap mapConfig) {
+    public void create(final ReadableMap mapConfig) {
         if (mapConfig == null) {
             return;
         }
@@ -363,7 +363,7 @@ && checkKey(mapConfig, "info4")) {
     }
 
     @ReactMethod
-    public void trackEvent(ReadableMap mapEvent) {
+    public void trackEvent(final ReadableMap mapEvent) {
         if (mapEvent == null) {
             return;
         }
@@ -454,32 +454,32 @@ public void trackEvent(ReadableMap mapEvent) {
     }
 
     @ReactMethod
-    public void setEnabled(Boolean enabled) {
+    public void setEnabled(final Boolean enabled) {
         com.adjust.sdk.Adjust.setEnabled(enabled);
     }
 
     @ReactMethod
-    public void isEnabled(Callback callback) {
+    public void isEnabled(final Callback callback) {
         callback.invoke(com.adjust.sdk.Adjust.isEnabled());
     }
 
     @ReactMethod
-    public void setReferrer(String referrer) {
+    public void setReferrer(final String referrer) {
         com.adjust.sdk.Adjust.setReferrer(referrer, getReactApplicationContext());
     }
 
     @ReactMethod
-    public void setOfflineMode(Boolean enabled) {
+    public void setOfflineMode(final Boolean enabled) {
         com.adjust.sdk.Adjust.setOfflineMode(enabled);
     }
 
     @ReactMethod
-    public void setPushToken(String token) {
+    public void setPushToken(final String token) {
         com.adjust.sdk.Adjust.setPushToken(token, getReactApplicationContext());
     }
 
     @ReactMethod
-    public void appWillOpenUrl(String strUri) {
+    public void appWillOpenUrl(final String strUri) {
         final Uri uri = Uri.parse(strUri);
         com.adjust.sdk.Adjust.appWillOpenUrl(uri, getReactApplicationContext());
     }
@@ -490,7 +490,7 @@ public void sendFirstPackages() {
     }
 
     @ReactMethod
-    public void trackAdRevenue(String source, String payload) {
+    public void trackAdRevenue(final String source, final String payload) {
         try {
             JSONObject jsonPayload = new JSONObject(payload);
             com.adjust.sdk.Adjust.trackAdRevenue(source, jsonPayload);
@@ -500,7 +500,7 @@ public void trackAdRevenue(String source, String payload) {
     }
 
     @ReactMethod
-    public void trackAdRevenueNew(ReadableMap mapAdRevenue) {
+    public void trackAdRevenueNew(final ReadableMap mapAdRevenue) {
         if (mapAdRevenue == null) {
             return;
         }
@@ -588,7 +588,7 @@ public void trackAdRevenueNew(ReadableMap mapAdRevenue) {
     }
 
     @ReactMethod
-    public void trackPlayStoreSubscription(ReadableMap mapEvent) {
+    public void trackPlayStoreSubscription(final ReadableMap mapEvent) {
         if (mapEvent == null) {
             return;
         }
@@ -676,22 +676,22 @@ public void trackPlayStoreSubscription(ReadableMap mapEvent) {
     }
 
     @ReactMethod
-    public void addSessionCallbackParameter(String key, String value) {
+    public void addSessionCallbackParameter(final String key, final String value) {
         com.adjust.sdk.Adjust.addSessionCallbackParameter(key, value);
     }
 
     @ReactMethod
-    public void addSessionPartnerParameter(String key, String value) {
+    public void addSessionPartnerParameter(final String key, final String value) {
         com.adjust.sdk.Adjust.addSessionPartnerParameter(key, value);
     }
 
     @ReactMethod
-    public void removeSessionCallbackParameter(String key) {
+    public void removeSessionCallbackParameter(final String key) {
         com.adjust.sdk.Adjust.removeSessionCallbackParameter(key);
     }
 
     @ReactMethod
-    public void removeSessionPartnerParameter(String key) {
+    public void removeSessionPartnerParameter(final String key) {
         com.adjust.sdk.Adjust.removeSessionPartnerParameter(key);
     }
 
@@ -716,12 +716,12 @@ public void disableThirdPartySharing() {
     }
 
     @ReactMethod
-    public void getIdfa(Callback callback) {
+    public void getIdfa(final Callback callback) {
         callback.invoke("");
     }
 
     @ReactMethod
-    public void getIdfv(Callback callback) {
+    public void getIdfv(final Callback callback) {
         callback.invoke("");
     }
 
@@ -736,22 +736,22 @@ public void onGoogleAdIdRead(String googleAdId) {
     }
 
     @ReactMethod
-    public void getAdid(Callback callback) {
+    public void getAdid(final Callback callback) {
         callback.invoke(com.adjust.sdk.Adjust.getAdid());
     }
 
     @ReactMethod
-    public void getAmazonAdId(Callback callback) {
+    public void getAmazonAdId(final Callback callback) {
         callback.invoke(com.adjust.sdk.Adjust.getAmazonAdId(getReactApplicationContext()));
     }
 
     @ReactMethod
-    public void getAttribution(Callback callback) {
+    public void getAttribution(final Callback callback) {
         callback.invoke(AdjustUtil.attributionToMap(com.adjust.sdk.Adjust.getAttribution()));
     }
 
     @ReactMethod
-    public void getSdkVersion(String sdkPrefix, Callback callback) {
+    public void getSdkVersion(final String sdkPrefix, final Callback callback) {
         String sdkVersion = com.adjust.sdk.Adjust.getSdkVersion();
         if (sdkVersion == null) {
             callback.invoke("");
@@ -766,22 +766,22 @@ public void convertUniversalLink(final String url, final String scheme, final Ca
     }
 
     @ReactMethod
-    public void requestTrackingAuthorizationWithCompletionHandler(Callback callback) {
+    public void requestTrackingAuthorizationWithCompletionHandler(final Callback callback) {
         callback.invoke("");
     }
 
     @ReactMethod
-    public void updateConversionValue(int conversionValue) {
+    public void updateConversionValue(final int conversionValue) {
         // do nothing
     }
 
     @ReactMethod
-    public void getAppTrackingAuthorizationStatus(Callback callback) {
+    public void getAppTrackingAuthorizationStatus(final Callback callback) {
         callback.invoke(-1);
     }
 
     @ReactMethod
-    public void trackThirdPartySharing(ReadableMap mapThirdPartySharing) {
+    public void trackThirdPartySharing(final ReadableMap mapThirdPartySharing) {
         if (mapThirdPartySharing == null) {
             return;
         }
@@ -828,12 +828,12 @@ public void trackThirdPartySharing(ReadableMap mapThirdPartySharing) {
     }
 
     @ReactMethod
-    public void trackMeasurementConsent(boolean measurementConsent) {
+    public void trackMeasurementConsent(final boolean measurementConsent) {
         com.adjust.sdk.Adjust.trackMeasurementConsent(measurementConsent);
     }
 
     @ReactMethod
-    public void verifyPlayStorePurchase(ReadableMap mapEvent, Callback callback) {
+    public void verifyPlayStorePurchase(final ReadableMap mapEvent, final Callback callback) {
         if (mapEvent == null) {
             return;
         }
@@ -874,7 +874,7 @@ public void onVerificationFinished(AdjustPurchaseVerificationResult verification
     }
 
     @ReactMethod
-    public void processDeeplink(String strUri, Callback callback) {
+    public void processDeeplink(final String strUri, final Callback callback) {
         final Uri uri = Uri.parse(strUri);
 
         // Process deeplink.
@@ -892,7 +892,7 @@ public void checkForNewAttStatus() {
     }
 
     @ReactMethod
-    public void getLastDeeplink(Callback callback) {
+    public void getLastDeeplink(final Callback callback) {
         callback.invoke("");
     }
 
@@ -937,7 +937,7 @@ public void teardown() {
     }
 
     @ReactMethod
-    public void setTestOptions(ReadableMap mapTest) {
+    public void setTestOptions(final ReadableMap mapTest) {
         if (mapTest == null) {
             return;
         }
@@ -1043,13 +1043,13 @@ public void onPause() {
         com.adjust.sdk.Adjust.onPause();
     }
 
-    private void sendEvent(ReactContext reactContext, String eventName, @Nullable WritableMap params) {
+    private void sendEvent(final ReactContext reactContext, final String eventName, final @Nullable WritableMap params) {
         reactContext
             .getJSModule(DeviceEventManagerModule.RCTDeviceEventEmitter.class)
             .emit(eventName, params);
     }
 
-    private boolean checkKey(ReadableMap map, String key) {
+    private boolean checkKey(final ReadableMap map, final String key) {
         return map.hasKey(key) && !map.isNull(key);
     }
 

android/src/main/java/com/adjust/sdk/Adjust.java

@@ -287,7 +287,7 @@ PODS:
   - React-jsinspector (0.69.4)
   - React-logger (0.69.4):
     - glog
-  - react-native-adjust (4.37.0):
+  - react-native-adjust (4.37.1):
     - Adjust (= 4.37.0)
     - React-Core
   - React-perflogger (0.69.4)
@@ -541,7 +541,7 @@ SPEC CHECKSUMS:
   React-jsiexecutor: a27badbbdbc0ff781813370736a2d1c7261181d4
   React-jsinspector: 8a3d3f5dcd23a91e8c80b1bf0e96902cd1dca999
   React-logger: 1088859f145b8f6dd0d3ed051a647ef0e3e80fad
-  react-native-adjust: 667739bee69c6878375b0d09bc0f35934fb72ed3
+  react-native-adjust: 0463129823eabe31ff28262295be713ba5f99d2c
   React-perflogger: cb386fd44c97ec7f8199c04c12b22066b0f2e1e0
   React-RCTActionSheet: f803a85e46cf5b4066c2ac5e122447f918e9c6e5
   React-RCTAnimation: 19c80fa950ccce7f4db76a2a7f2cf79baae07fc7

example/ios/Podfile.lock

@@ -5750,10 +5750,10 @@ react-is@^17.0.1:
   integrity sha512-w2GsyukL62IJnlaff/nRegPQR94C/XXamvMWmSHRJ4y7Ts/4ocGRmTHvOs8PSE6pB3dWOrD/nueuU5sduBsQ4w==
 
 react-native-adjust-oaid@../plugins/oaid:
-  version "4.37.0"
+  version "4.37.1"
 
 react-native-adjust@../temp:
-  version "4.37.0"
+  version "4.37.1"
 
 react-native-codegen@^0.69.1:
   version "0.69.2"

example/yarn.lock

@@ -136,7 +136,7 @@ Adjust.getAmazonAdId = function(callback) {
 };
 
 Adjust.getSdkVersion = function(callback) {
-    module_adjust.getSdkVersion("react-native4.37.0", callback);
+    module_adjust.getSdkVersion("react-native4.37.1", callback);
 };
 
 Adjust.setReferrer = function(referrer) {
@@ -280,7 +280,7 @@ Adjust.onPause = function(testParam) {
 // AdjustConfig
 
 var AdjustConfig = function(appToken, environment) {
-    this.sdkPrefix = "react-native4.37.0";
+    this.sdkPrefix = "react-native4.37.1";
     this.appToken = appToken;
     this.environment = environment;
     this.logLevel = null;

index.js

@@ -1,7 +1,7 @@
 {
     "name": "react-native-adjust",
     "description": "Adjust React Native SDK",
-    "version": "4.37.0",
+    "version": "4.37.1",
     "main": "index.js",
     "author": "Adjust",
     "license": "MIT",

package.json

@@ -1,7 +1,7 @@
 {
     "name": "react-native-adjust-oaid",
     "description": "Adjust React Native OAID plugin",
-    "version": "4.37.0",
+    "version": "4.37.1",
     "main": "index.js",
     "author": "Adjust",
     "license": "MIT",