Add --swc shorthand for the built-in swc transpiler; graduate the swc transpiler out of experimental status (#1536)

* Add --swc shorthand for the built-in swc transpiler; graduate the swc transpiler out of experimental status

* lint-fix

* fix

* fix tests

* Improve swc / transpiler tests to prove that third-party transpiler was invoked

* lintfix

Author: cspotcode

package.json

@@ -23,6 +23,7 @@
     "./esm.mjs": "./esm.mjs",
     "./esm/transpile-only": "./esm/transpile-only.mjs",
     "./esm/transpile-only.mjs": "./esm/transpile-only.mjs",
+    "./transpilers/swc": "./transpilers/swc.js",
     "./transpilers/swc-experimental": "./transpilers/swc-experimental.js",
     "./node10/tsconfig.json": "./node10/tsconfig.json",
     "./node12/tsconfig.json": "./node12/tsconfig.json",

src/bin.ts

@@ -55,6 +55,7 @@ export function main(
         '--ignore': [String],
         '--transpile-only': Boolean,
         '--transpiler': String,
+        '--swc': Boolean,
         '--type-check': Boolean,
         '--compiler-host': Boolean,
         '--pretty': Boolean,
@@ -116,6 +117,7 @@ export function main(
     '--transpile-only': transpileOnly,
     '--type-check': typeCheck,
     '--transpiler': transpiler,
+    '--swc': swc,
     '--compiler-host': compilerHost,
     '--pretty': pretty,
     '--skip-project': skipProject,
@@ -145,6 +147,7 @@ export function main(
     --show-config                   Print resolved configuration and exit
 
     -T, --transpile-only            Use TypeScript's faster \`transpileModule\` or a third-party transpiler
+    --swc                           Use the swc transpiler
     -H, --compiler-host             Use TypeScript's compiler host API
     -I, --ignore [pattern]          Override the path patterns to skip compilation
     -P, --project [path]            Path to TypeScript JSON project file
@@ -256,6 +259,7 @@ export function main(
     experimentalReplAwait: noExperimentalReplAwait ? false : undefined,
     typeCheck,
     transpiler,
+    swc,
     compilerHost,
     ignore,
     preferTsExts,

src/configuration.ts

@@ -276,6 +276,7 @@ function filterRecognizedTsConfigTsNodeOptions(
     scopeDir,
     moduleTypes,
     experimentalReplAwait,
+    swc,
     ...unrecognized
   } = jsonObject as TsConfigOptions;
   const filteredTsConfigOptions = {
@@ -298,6 +299,7 @@ function filterRecognizedTsConfigTsNodeOptions(
     scope,
     scopeDir,
     moduleTypes,
+    swc,
   };
   // Use the typechecker to make sure this implementation has the correct set of properties
   const catchExtraneousProps: keyof TsConfigOptions = (null as any) as keyof typeof filteredTsConfigOptions;

src/index.ts

@@ -256,6 +256,12 @@ export interface CreateOptions {
    * Specify a custom transpiler for use with transpileOnly
    */
   transpiler?: string | [string, object];
+  /**
+   * Transpile with swc instead of the TypeScript compiler, and skip typechecking.
+   *
+   * Equivalent to setting both `transpileOnly: true` and `transpiler: 'ts-node/transpilers/swc'`
+   */
+  swc?: boolean;
   /**
    * Paths which should not be compiled.
    *
@@ -608,11 +614,33 @@ export function create(rawOptions: CreateOptions = {}): Service {
     ({ compiler, ts } = loadCompiler(options.compiler, configFilePath));
   }
 
+  // swc implies two other options
+  // typeCheck option was implemented specifically to allow overriding tsconfig transpileOnly from the command-line
+  // So we should allow using typeCheck to override swc
+  if (options.swc && !options.typeCheck) {
+    if (options.transpileOnly === false) {
+      throw new Error(
+        "Cannot enable 'swc' option with 'transpileOnly: false'.  'swc' implies 'transpileOnly'."
+      );
+    }
+    if (options.transpiler) {
+      throw new Error(
+        "Cannot specify both 'swc' and 'transpiler' options.  'swc' uses the built-in swc transpiler."
+      );
+    }
+  }
+
   const readFile = options.readFile || ts.sys.readFile;
   const fileExists = options.fileExists || ts.sys.fileExists;
   // typeCheck can override transpileOnly, useful for CLI flag to override config file
   const transpileOnly =
-    options.transpileOnly === true && options.typeCheck !== true;
+    (options.transpileOnly === true || options.swc === true) &&
+    options.typeCheck !== true;
+  const transpiler = options.transpiler
+    ? options.transpiler
+    : options.swc
+    ? require.resolve('./transpilers/swc.js')
+    : undefined;
   const transformers = options.transformers || undefined;
   const diagnosticFilters: Array<DiagnosticFilter> = [
     {
@@ -668,17 +696,15 @@ export function create(rawOptions: CreateOptions = {}): Service {
     );
   }
   let customTranspiler: Transpiler | undefined = undefined;
-  if (options.transpiler) {
+  if (transpiler) {
     if (!transpileOnly)
       throw new Error(
         'Custom transpiler can only be used when transpileOnly is enabled.'
       );
     const transpilerName =
-      typeof options.transpiler === 'string'
-        ? options.transpiler
-        : options.transpiler[0];
+      typeof transpiler === 'string' ? transpiler : transpiler[0];
     const transpilerOptions =
-      typeof options.transpiler === 'string' ? {} : options.transpiler[1] ?? {};
+      typeof transpiler === 'string' ? {} : transpiler[1] ?? {};
     // TODO mimic fixed resolution logic from loadCompiler main
     // TODO refactor into a more generic "resolve dep relative to project" helper
     const transpilerPath = require.resolve(transpilerName, {

src/test/index.spec.ts

@@ -70,6 +70,7 @@ test.suite('ts-node', (test) => {
     testsDirRequire.resolve('ts-node/esm/transpile-only');
     testsDirRequire.resolve('ts-node/esm/transpile-only.mjs');
 
+    testsDirRequire.resolve('ts-node/transpilers/swc');
     testsDirRequire.resolve('ts-node/transpilers/swc-experimental');
 
     testsDirRequire.resolve('ts-node/node10/tsconfig.json');
@@ -304,21 +305,31 @@ test.suite('ts-node', (test) => {
       expect(err.message).toMatch('error TS1003: Identifier expected');
     });
 
-    test('should support third-party transpilers via --transpiler', async () => {
-      const { err, stdout } = await exec(
-        `${CMD_TS_NODE_WITHOUT_PROJECT_FLAG} --transpiler ts-node/transpilers/swc-experimental transpile-only-swc`
-      );
-      expect(err).toBe(null);
-      expect(stdout).toMatch('Hello World!');
-    });
-
-    test('should support third-party transpilers via tsconfig', async () => {
-      const { err, stdout } = await exec(
-        `${CMD_TS_NODE_WITHOUT_PROJECT_FLAG} transpile-only-swc-via-tsconfig`
-      );
-      expect(err).toBe(null);
-      expect(stdout).toMatch('Hello World!');
-    });
+    for (const flavor of [
+      '--transpiler ts-node/transpilers/swc transpile-only-swc',
+      '--transpiler ts-node/transpilers/swc-experimental transpile-only-swc',
+      '--swc transpile-only-swc',
+      'transpile-only-swc-via-tsconfig',
+      'transpile-only-swc-shorthand-via-tsconfig',
+    ]) {
+      test(`should support swc and third-party transpilers: ${flavor}`, async () => {
+        const { err, stdout } = await exec(
+          `${CMD_TS_NODE_WITHOUT_PROJECT_FLAG} ${flavor}`,
+          {
+            env: {
+              ...process.env,
+              NODE_OPTIONS: `${
+                process.env.NODE_OPTIONS || ''
+              } --require ${require.resolve('../../tests/spy-swc-transpiler')}`,
+            },
+          }
+        );
+        expect(err).toBe(null);
+        expect(stdout).toMatch(
+          'Hello World! swc transpiler invocation count: 1\n'
+        );
+      });
+    }
 
     if (semver.gte(process.version, '12.16.0')) {
       test('swc transpiler supports native ESM emit', async () => {

tests/spy-swc-transpiler.js

@@ -0,0 +1,16 @@
+// Spy on the swc transpiler so that tests can prove it was used rather than
+// TypeScript's `transpileModule`.
+const swcTranspiler = require('ts-node/transpilers/swc');
+
+global.swcTranspilerCalls = 0;
+
+const wrappedCreate = swcTranspiler.create;
+swcTranspiler.create = function (...args) {
+  const transpiler = wrappedCreate(...args);
+  const wrappedTranspile = transpiler.transpile;
+  transpiler.transpile = function (...args) {
+    global.swcTranspilerCalls++;
+    return wrappedTranspile.call(this, ...args);
+  };
+  return transpiler;
+};

tests/transpile-only-swc-shorthand-via-tsconfig/index.ts

@@ -0,0 +1,13 @@
+// Test for #1343
+const Decorator = function () {};
+@Decorator
+class World {}
+
+// intentional type errors to check transpile-only ESM loader skips type checking
+parseInt(1101, 2);
+const x: number = `Hello ${World.name}! swc transpiler invocation count: ${global.swcTranspilerCalls}`;
+console.log(x);
+
+// test module type emit
+import { readFileSync } from 'fs';
+readFileSync;

tests/transpile-only-swc-shorthand-via-tsconfig/tsconfig.json

@@ -0,0 +1,12 @@
+{
+  "ts-node": {
+    "swc": true
+  },
+  "compilerOptions": {
+    "target": "ES2018",
+    "module": "CommonJS",
+    "allowJs": true,
+    "jsx": "react",
+    "experimentalDecorators": true
+  }
+}

tests/transpile-only-swc-via-tsconfig/index.ts

@@ -5,7 +5,7 @@ class World {}
 
 // intentional type errors to check transpile-only ESM loader skips type checking
 parseInt(1101, 2);
-const x: number = `Hello ${World.name}!`;
+const x: number = `Hello ${World.name}! swc transpiler invocation count: ${global.swcTranspilerCalls}`;
 console.log(x);
 
 // test module type emit

tests/transpile-only-swc-via-tsconfig/tsconfig.json

@@ -1,7 +1,7 @@
 {
   "ts-node": {
     "transpileOnly": true,
-    "transpiler": "ts-node/transpilers/swc-experimental"
+    "transpiler": "ts-node/transpilers/swc"
   },
   "compilerOptions": {
     "target": "ES2018",