Skip to content

Conversation

z-Fng
Copy link
Contributor

@z-Fng z-Fng commented Sep 29, 2025

This PR makes the following changes:

  • v2rayn-pre:
    • Update to version 7.15.0, drop 32bit support, fix checkver & autoupdate.
    • Remove reliance on Xray core.

Relates to:

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

Summary by CodeRabbit

  • Chores
    • Updated v2rayN (Pre-release) to version 7.15.0 with refreshed description.
    • Streamlined packages to per-architecture releases (64-bit and ARM64); discontinued 32-bit support.
    • Removed external dependency on Xray.
    • Shortcut now labeled “v2rayN (Pre-release)” for clearer identification.
    • Simplified installation layout and removed legacy installer/uninstaller steps.
    • Improved version checking and auto-update to better track pre-release builds.

Copy link

coderabbitai bot commented Sep 29, 2025

Walkthrough

Updated the Scoop manifest bucket/v2rayn-pre.json: bumped version to 7.15.0, revised description, removed depends, restructured architectures to 64bit and arm64 with new per-arch URLs, hashes, and extract_dir; removed top-level extract_dir, pre_install, and uninstaller; adjusted shortcut label; added jsonpath for checkver while retaining the old regex; updated autoupdate to per-arch assets.

Changes

Cohort / File(s) Summary
Scoop manifest update
bucket/v2rayn-pre.json
Version 6.607.15.0; description updated; removed public depends; architecture entries reworked to 64bit and arm64 with new url, hash, and per-arch extract_dir; removed top-level extract_dir, pre_install, and uninstaller; shortcut label changed to "v2rayN (Pre-release)"; checkver now adds jsonpath ($[?(@.prerelease == true)].tag_name) while keeping the existing regex; autoupdate URLs updated to per-arch v2rayN-windows-64.zip and v2rayN-windows-arm64.zip.

Sequence Diagram(s)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

In my burrow I nudge the manifest bright,
Pre-release 7.15.0 hops into sight.
Two arches now open, bundles unzipped,
Old scripts and relies gently stripped.
A whisker-twitch cheer — tidy and light! 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title follows the conventional <manifest-name>: <summary> format and clearly identifies the manifest being updated, the new version number, the removal of 32-bit support, and fixes to checkver and autoupdate, which directly reflect the main changes in the PR. It is concise, specific, and provides enough context for a reviewer to understand the primary modifications without including extraneous details.
Description Check ✅ Passed The description outlines the key updates, references the related PR, and includes the required checklist items for title convention and reading the contributing guide, matching the template’s structure. The “Relates to” section successfully links to the associated issue even though it uses a full URL instead of the shorthand notation, but it still fulfills the template’s requirement to reference related work.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

v2rayn-pre

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 400a4b6 and db71a8d.

📒 Files selected for processing (1)
  • bucket/v2rayn-pre.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: WindowsPowerShell
  • GitHub Check: PullRequestHandler
🔇 Additional comments (4)
bucket/v2rayn-pre.json (4)

2-3: Version/description: looks good.
Bump and wording are fine.


26-26: Shortcut label change: OK.
Name is clear and matches app identity.


12-20: Incorrect prefix suggestion; release tags lack a ‘v’ prefix. Verified that the correct tag is “7.15.0” and URLs without “v” return HTTP 302 while those with “v” return 404—no changes needed.

Likely an incorrect or invalid review comment.


37-41: Autoupdate URLs must include the v prefix
Apply to bucket/v2rayn-pre.json:

-                "url": "https://github.com/2dust/v2rayN/releases/download/$version/v2rayN-windows-64.zip"
+                "url": "https://github.com/2dust/v2rayN/releases/download/v$version/v2rayN-windows-64.zip"
@@
-                "url": "https://github.com/2dust/v2rayN/releases/download/$version/v2rayN-windows-arm64.zip"
+                "url": "https://github.com/2dust/v2rayN/releases/download/v$version/v2rayN-windows-arm64.zip"

Manually verify the URLs resolve (e.g., curl -I https://github.com/2dust/v2rayN/releases/download/v<latest>/v2rayN-windows-64.zip).

@z-Fng
Copy link
Contributor Author

z-Fng commented Sep 29, 2025

/verify

Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

v2rayn-pre

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between db71a8d and 148c693.

📒 Files selected for processing (1)
  • bucket/v2rayn-pre.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: WindowsPowerShell
🔇 Additional comments (4)
bucket/v2rayn-pre.json (4)

2-3: LGTM on version bump and description.
No concerns here.


26-26: Shortcut label change looks good.
Name is clear and distinguishes pre‑release.


32-33: checkver should select a single prerelease and normalize the tag.
Current jsonpath returns an array of tag_names; add [0] to pick the latest prerelease entry, then use regex to strip the leading 'v'. This also addresses the earlier comment.

Apply:

-        "jsonpath": "$[?(@.prerelease == true)].tag_name",
-        "regex": "(?:v|V)?([\\d.]+)"
+        "jsonpath": "$[?(@.prerelease==true)][0].tag_name",
+        "regex": "v?([\\d.]+)"

12-14: Confirm SHA256 hashes and extract_dir names

  • Manually download both v2rayN-windows-64.zip and v2rayN-windows-arm64.zip from https://github.com/2dust/v2rayN/releases/download/7.15.0/ and verify their SHA256 sums match the "hash" entries in bucket/v2rayn-pre.json.
  • Open each archive to ensure the top-level folder is exactly v2rayN-windows-64 and v2rayN-windows-arm64, matching the "extract_dir" values.

@z-Fng z-Fng merged commit 9f8e284 into ScoopInstaller:master Sep 29, 2025
3 checks passed
@z-Fng z-Fng deleted the udpate-v2rayn-pre branch September 29, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: v2rayn-pre installation script fails to hard-link Xray binaries
1 participant