-
-
Notifications
You must be signed in to change notification settings - Fork 236
v2rayn-pre: Update to version 7.15.0, drop 32bit support, fix checkver & autoupdate #2494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughUpdated the Scoop manifest Changes
Sequence Diagram(s)Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
All changes look good. Wait for review from human collaborators. v2rayn-pre
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
bucket/v2rayn-pre.json
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: WindowsPowerShell
- GitHub Check: PullRequestHandler
🔇 Additional comments (4)
bucket/v2rayn-pre.json (4)
2-3
: Version/description: looks good.
Bump and wording are fine.
26-26
: Shortcut label change: OK.
Name is clear and matches app identity.
12-20
: Incorrect prefix suggestion; release tags lack a ‘v’ prefix. Verified that the correct tag is “7.15.0” and URLs without “v” return HTTP 302 while those with “v” return 404—no changes needed.Likely an incorrect or invalid review comment.
37-41
: Autoupdate URLs must include thev
prefix
Apply to bucket/v2rayn-pre.json:- "url": "https://github.com/2dust/v2rayN/releases/download/$version/v2rayN-windows-64.zip" + "url": "https://github.com/2dust/v2rayN/releases/download/v$version/v2rayN-windows-64.zip" @@ - "url": "https://github.com/2dust/v2rayN/releases/download/$version/v2rayN-windows-arm64.zip" + "url": "https://github.com/2dust/v2rayN/releases/download/v$version/v2rayN-windows-arm64.zip"Manually verify the URLs resolve (e.g.,
curl -I https://github.com/2dust/v2rayN/releases/download/v<latest>/v2rayN-windows-64.zip
).
db71a8d
to
148c693
Compare
/verify |
All changes look good. Wait for review from human collaborators. v2rayn-pre
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
bucket/v2rayn-pre.json
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: WindowsPowerShell
🔇 Additional comments (4)
bucket/v2rayn-pre.json (4)
2-3
: LGTM on version bump and description.
No concerns here.
26-26
: Shortcut label change looks good.
Name is clear and distinguishes pre‑release.
32-33
: checkver should select a single prerelease and normalize the tag.
Current jsonpath returns an array of tag_names; add [0] to pick the latest prerelease entry, then use regex to strip the leading 'v'. This also addresses the earlier comment.Apply:
- "jsonpath": "$[?(@.prerelease == true)].tag_name", - "regex": "(?:v|V)?([\\d.]+)" + "jsonpath": "$[?(@.prerelease==true)][0].tag_name", + "regex": "v?([\\d.]+)"
12-14
: Confirm SHA256 hashes and extract_dir names
- Manually download both
v2rayN-windows-64.zip
andv2rayN-windows-arm64.zip
fromhttps://github.com/2dust/v2rayN/releases/download/7.15.0/
and verify their SHA256 sums match the"hash"
entries inbucket/v2rayn-pre.json
.- Open each archive to ensure the top-level folder is exactly
v2rayN-windows-64
andv2rayN-windows-arm64
, matching the"extract_dir"
values.
This PR makes the following changes:
v2rayn-pre
:Relates to:
<manifest-name[@version]|chore>: <general summary of the pull request>
Summary by CodeRabbit