Skip to content

Conversation

artiga033
Copy link
Contributor

@artiga033 artiga033 commented Sep 25, 2025

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

Summary by CodeRabbit

  • New Features

    • Added Windows ARM64 build support for FFmpeg Nightly and FFmpeg Shared Nightly with auto-update.
  • Chores

    • Updated FFmpeg Nightly to the latest build; refreshed 64-bit checksum.
    • Updated FFmpeg Shared Nightly (build updated); added ARM64 artifacts and auto-update entries.

Copy link

coderabbitai bot commented Sep 25, 2025

Walkthrough

Adds arm64 architecture entries and corresponding autoupdate entries to two Scoop manifest files for FFmpeg nightly builds; updates versions and hashes where applicable.

Changes

Cohort / File(s) Summary
FFmpeg nightly (static)
bucket/ffmpeg-nightly.json
Added architecture.arm64 with url, hash, and extract_dir; added autoupdate.architecture.arm64 with url; updated top-level version and adjusted existing architecture.64bit.hash.
FFmpeg nightly (shared)
bucket/ffmpeg-shared-nightly.json
Added architecture.arm64 under architecture.64bit with url, hash, and extract_dir; added autoupdate.architecture.64bit.arm64 with url and extract_dir; bumped version.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A bunny taps the nightly drum,
New arches hop—arm64 has come!
Manifests bloom with hashes bright,
Versions set for morning light.
I nibble joy: the builds take flight! 🥕🐇

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The description retains only the unmodified template comments and checklist, without any actual summary of the changes, linked issue references, or details on implementation, purpose, or testing. Please replace the placeholder comments with a clear summary of what the PR changes, link the relevant issue using “Closes #…” or “Relates to #…”, and include any necessary implementation details and testing instructions.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title concisely and accurately summarizes the primary change—adding arm64 support to the ffmpeg-nightly manifests—without unnecessary detail or ambiguity.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9dc9307 and 0a589ec.

📒 Files selected for processing (2)
  • bucket/ffmpeg-nightly.json (2 hunks)
  • bucket/ffmpeg-shared-nightly.json (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • bucket/ffmpeg-nightly.json
🔇 Additional comments (2)
bucket/ffmpeg-shared-nightly.json (2)

12-15: Arm64 block mirrors the existing win64 stanza well.

Thanks for cloning the established structure (url/hash/extract_dir) for the new architecture entry; everything lines up cleanly.


34-36: Autoupdate wiring for arm64 looks spot on.

Reusing $matchTime and $matchHash keeps the nightly arm64 artifact in sync without extra regex work. Nicely done.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

ffmpeg-nightly

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

ffmpeg-shared-nightly

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@z-Fng z-Fng force-pushed the ffmpeg-nightly-arm64 branch from 9dc9307 to 0a589ec Compare September 27, 2025 19:20
@z-Fng z-Fng changed the title ffmpeg-nightly: add arm64 ffmpeg(-shared)-nightly: Add arm64 support Sep 27, 2025
@z-Fng
Copy link
Contributor

z-Fng commented Sep 27, 2025

/verify

Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

ffmpeg-nightly

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

ffmpeg-shared-nightly

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@z-Fng z-Fng merged commit 2bf363f into ScoopInstaller:master Sep 27, 2025
3 checks passed
@z-Fng
Copy link
Contributor

z-Fng commented Sep 27, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants