chore(internal/pyright): enable reportImplicitOverride

Author: RobertCraigie

databases/constants.py

@@ -124,6 +124,7 @@ def _fromdir(path: str) -> list[str]:
     'reportUnknownVariableType': False,
     'reportUnknownArgumentType': False,
     # very strict errors
+    'reportImplicitOverride': True,
     'reportUnusedCallResult': False,
     'reportImplicitStringConcatenation': False,
     'reportCallInDefaultInitializer': True,

databases/utils.py

@@ -3,7 +3,7 @@
 import os
 from typing import Set
 from pathlib import Path
-from typing_extensions import Literal, get_args
+from typing_extensions import Literal, get_args, override
 
 from pydantic import BaseModel
 from syrupy.extensions.amber import AmberSnapshotExtension
@@ -57,6 +57,7 @@ class AmberSharedExtension(AmberSnapshotExtension):
     """Syrupy extension that stores the snapshots in a parent __shared_snapshots__ dir"""
 
     @property
+    @override
     def _dirname(self) -> str:
         test_dir = Path(self.test_location.filepath).parent
         if test_dir.is_relative_to(SYNC_TESTS_DIR):

lib/pyright/_pyright.py

@@ -9,6 +9,7 @@ class PyrightDiagnostics(TypedDict, total=False):
     reportUnusedImport: bool
     reportPrivateUsage: bool
     reportImportCycles: bool
+    reportImplicitOverride: bool
     reportUnusedCallResult: bool
     reportUnknownMemberType: bool
     reportUnknownVariableType: bool

pyproject.toml

@@ -69,6 +69,8 @@ typeCheckingMode = "strict"
 reportUnusedImport = true
 reportPrivateUsage = false
 
+reportImplicitOverride = true
+
 # TODO: pending some major refactoring, enable this
 reportImportCycles = false
 

src/prisma/_async_http.py

@@ -1,5 +1,6 @@
 import json
 from typing import Any
+from typing_extensions import override
 
 import httpx
 
@@ -12,19 +13,23 @@
 class AsyncHTTP(AbstractHTTP[httpx.AsyncClient, httpx.Response]):
     session: httpx.AsyncClient
 
+    @override
     async def download(self, url: str, dest: str) -> None:
         async with self.session.stream('GET', url, timeout=None) as resp:
             resp.raise_for_status()
             with open(dest, 'wb') as fd:
                 async for chunk in resp.aiter_bytes():
                     fd.write(chunk)
 
+    @override
     async def request(self, method: Method, url: str, **kwargs: Any) -> 'Response':
         return Response(await self.session.request(method, url, **kwargs))
 
+    @override
     def open(self) -> None:
         self.session = httpx.AsyncClient(**self.session_kwargs)
 
+    @override
     async def close(self) -> None:
         if self.should_close():
             await self.session.aclose()
@@ -45,15 +50,19 @@ class Response(AbstractResponse[httpx.Response]):
     __slots__ = ()
 
     @property
+    @override
     def status(self) -> int:
         return self.original.status_code
 
     @property
+    @override
     def headers(self) -> httpx.Headers:
         return self.original.headers
 
+    @override
     async def json(self, **kwargs: Any) -> Any:
         return json.loads(await self.original.aread(), **kwargs)
 
+    @override
     async def text(self, **kwargs: Any) -> str:
         return ''.join([part async for part in self.original.aiter_text(**kwargs)])

src/prisma/_config.py

@@ -4,6 +4,7 @@
 
 from typing import TYPE_CHECKING, List, Union, ClassVar, Optional
 from pathlib import Path
+from typing_extensions import override
 
 import tomlkit
 import pydantic
@@ -119,6 +120,7 @@ def parse(cls, **kwargs: object) -> Config:
 
 
 class LazyConfigProxy(LazyProxy[Config]):
+    @override
     def __load__(self) -> Config:
         return Config.load()
 

src/prisma/_proxy.py

@@ -2,6 +2,7 @@
 
 from abc import ABC, abstractmethod
 from typing import Generic, TypeVar, Iterable, cast
+from typing_extensions import override
 
 T = TypeVar('T')
 
@@ -17,12 +18,15 @@ def __init__(self) -> None:
     def __getattr__(self, attr: str) -> object:
         return getattr(self.__get_proxied__(), attr)
 
+    @override
     def __repr__(self) -> str:
         return repr(self.__get_proxied__())
 
+    @override
     def __str__(self) -> str:
         return str(self.__get_proxied__())
 
+    @override
     def __dir__(self) -> Iterable[str]:
         return self.__get_proxied__().__dir__()
 

src/prisma/_sync_http.py

@@ -1,4 +1,5 @@
 from typing import Any
+from typing_extensions import override
 
 import httpx
 
@@ -11,19 +12,23 @@
 class SyncHTTP(AbstractHTTP[httpx.Client, httpx.Response]):
     session: httpx.Client
 
+    @override
     def download(self, url: str, dest: str) -> None:
         with self.session.stream('GET', url, timeout=None) as resp:
             resp.raise_for_status()
             with open(dest, 'wb') as fd:
                 for chunk in resp.iter_bytes():
                     fd.write(chunk)
 
+    @override
     def request(self, method: Method, url: str, **kwargs: Any) -> 'Response':
         return Response(self.session.request(method, url, **kwargs))
 
+    @override
     def open(self) -> None:
         self.session = httpx.Client(**self.session_kwargs)
 
+    @override
     def close(self) -> None:
         if self.should_close():
             self.session.close()
@@ -42,15 +47,19 @@ class Response(AbstractResponse[httpx.Response]):
     __slots__ = ()
 
     @property
+    @override
     def status(self) -> int:
         return self.original.status_code
 
     @property
+    @override
     def headers(self) -> httpx.Headers:
         return self.original.headers
 
+    @override
     def json(self, **kwargs: Any) -> Any:
         return self.original.json(**kwargs)
 
+    @override
     def text(self, **kwargs: Any) -> str:
         return self.original.content.decode(**kwargs)

src/prisma/cli/_node.py

@@ -9,7 +9,7 @@
 from abc import ABC, abstractmethod
 from typing import IO, Any, Union, Mapping, cast
 from pathlib import Path
-from typing_extensions import Literal
+from typing_extensions import Literal, override
 
 from .. import config
 from .._proxy import LazyProxy
@@ -117,9 +117,11 @@ def __init__(
         self.resolver = resolver
 
     @property
+    @override
     def target_bin(self) -> Path:
         return self.path.parent
 
+    @override
     def __run__(
         self,
         *args: str,
@@ -216,6 +218,7 @@ def __init__(self, *, target: Target) -> None:
         self.target = target
         self.resolver = 'nodejs-bin'
 
+    @override
     def __run__(
         self,
         *args: str,
@@ -257,6 +260,7 @@ def node_path(self) -> Path:
         return Path(nodejs.node.path)
 
     @property
+    @override
     def target_bin(self) -> Path:
         return Path(self.node_path).parent
 
@@ -397,6 +401,7 @@ def __init__(self, target: Target) -> None:
         super().__init__()
         self.target = target
 
+    @override
     def __load__(self) -> Node:
         return resolve(self.target)
 

src/prisma/cli/utils.py

@@ -16,6 +16,7 @@
     overload,
 )
 from pathlib import Path
+from typing_extensions import override
 
 import click
 
@@ -30,6 +31,7 @@ class PrismaCLI(click.MultiCommand):
     base_package: str = 'prisma.cli.commands'
     folder: Path = Path(__file__).parent / 'commands'
 
+    @override
     def list_commands(self, ctx: click.Context) -> List[str]:  # noqa: ARG002
         commands: List[str] = []
 
@@ -46,6 +48,7 @@ def list_commands(self, ctx: click.Context) -> List[str]:  # noqa: ARG002
         commands.sort()
         return commands
 
+    @override
     def get_command(self, ctx: click.Context, cmd_name: str) -> Optional[click.Command]:  # noqa: ARG002
         name = f'{self.base_package}.{cmd_name}'
         if not module_exists(name):
@@ -66,6 +69,7 @@ def get_command(self, ctx: click.Context, cmd_name: str) -> Optional[click.Comma
 class PathlibPath(click.Path):
     """A Click path argument that returns a pathlib Path, not a string"""
 
+    @override
     def convert(
         self,
         value: str | os.PathLike[str],
@@ -93,6 +97,7 @@ def __init__(self, enum: Type[Enum]) -> None:
         self.__enum = enum
         super().__init__([item.value for item in enum.__members__.values()])
 
+    @override
     def convert(
         self,
         value: str,