refactor(router): replace asyncRequestStore with global qcAsyncRequestStore for improved async handling

Author: JerryWu1234

packages/qwik-router/global.d.ts

@@ -5,7 +5,7 @@ type RequestEventInternal =
   import('./middleware/request-handler/request-event').RequestEventInternal;
 type AsyncStore = import('node:async_hooks').AsyncLocalStorage<RequestEventInternal>;
 type SerializationStrategy = import('@qwik.dev/core/internal').SerializationStrategy;
-
+declare var qcAsyncRequestStore: AsyncStore | undefined;
 declare var _qwikActionsMap: Map<string, ActionInternal> | undefined;
 
 type ExperimentalFeatures = import('@qwik.dev/core/optimizer').ExperimentalFeatures;

packages/qwik-router/src/middleware/request-handler/async-request-store.ts

@@ -20,7 +20,7 @@ import {
   RewriteMessage,
 } from '@qwik.dev/router/middleware/request-handler';
 import { encoder, getRouteLoaderPromise } from './resolve-request-handlers';
-import { asyncRequestStore } from './async-request-store';
+
 import type {
   CacheControl,
   CacheControlTarget,
@@ -81,7 +81,7 @@ export function createRequestEvent(
 
     while (routeModuleIndex < requestHandlers.length) {
       const moduleRequestHandler = requestHandlers[routeModuleIndex];
-      const asyncStore = asyncRequestStore;
+      const asyncStore = globalThis.qcAsyncRequestStore;
       const result = asyncStore?.run
         ? asyncStore.run(requestEv, moduleRequestHandler, requestEv)
         : moduleRequestHandler(requestEv);

packages/qwik-router/src/middleware/request-handler/request-event.ts

@@ -9,7 +9,6 @@ import { getErrorHtml } from './error-handler';
 import { createRequestEvent, getRequestMode, type RequestEventInternal } from './request-event';
 import { encoder } from './resolve-request-handlers';
 import { withLocale } from '@qwik.dev/core';
-import { asyncRequestStore } from './async-request-store';
 import type { ServerRequestEvent, StatusCodes } from './types';
 // Import separately to avoid duplicate imports in the vite dev server
 import {
@@ -19,6 +18,19 @@ import {
   ServerError,
 } from '@qwik.dev/router/middleware/request-handler';
 
+let asyncStore: AsyncStore | undefined;
+import('node:async_hooks')
+  .then((module) => {
+    const AsyncLocalStorage = module.AsyncLocalStorage;
+    asyncStore = new AsyncLocalStorage<RequestEventInternal>();
+    globalThis.qcAsyncRequestStore = asyncStore;
+  })
+  .catch((err) => {
+    console.warn(
+      'AsyncLocalStorage not available, continuing without it. This might impact concurrent server calls.',
+      err
+    );
+  });
 export interface QwikRouterRun<T> {
   response: Promise<T | null>;
   requestEv: RequestEvent;
@@ -47,8 +59,8 @@ export function runQwikRouter<T>(
     requestEv,
     completion: withLocale(
       requestEv.locale(),
-      asyncRequestStore
-        ? () => asyncRequestStore!.run(requestEv, runNext, requestEv, rebuildRouteInfo, resolve!)
+      asyncStore
+        ? () => asyncStore!.run(requestEv, runNext, requestEv, rebuildRouteInfo, resolve!)
         : () => runNext(requestEv, rebuildRouteInfo, resolve!)
     ),
   };

packages/qwik-router/src/middleware/request-handler/user-response.ts

@@ -14,7 +14,6 @@ import type {
   ContentModuleHead,
 } from './types';
 import { isPromise } from './utils';
-import { asyncRequestStore } from '../../middleware/request-handler/async-request-store';
 
 export const resolveHead = (
   endpoint: EndpointResponse | ClientPageData,
@@ -54,25 +53,18 @@ export const resolveHead = (
     }
   }
   if (fns.length) {
-    const hasAsyncStore = !!asyncRequestStore;
     const headProps: DocumentHeadProps = {
       head,
-      withLocale: hasAsyncStore ? (fn) => fn() : (fn) => withLocale(locale, fn),
+      withLocale: (fn) => withLocale(locale, fn),
       resolveValue: getData,
       ...routeLocation,
     };
 
-    if (hasAsyncStore) {
+    withLocale(locale, () => {
       for (const fn of fns) {
         resolveDocumentHead(head, fn(headProps));
       }
-    } else {
-      withLocale(locale, () => {
-        for (const fn of fns) {
-          resolveDocumentHead(head, fn(headProps));
-        }
-      });
-    }
+    });
   }
 
   return head;

packages/qwik-router/src/runtime/src/head.ts

@@ -64,7 +64,6 @@ import type {
 import { useAction, useLocation, useQwikRouterEnv } from './use-functions';
 
 import type { FormSubmitCompletedDetail } from './form-component';
-import { asyncRequestStore } from '../../middleware/request-handler/async-request-store';
 import { deepFreeze } from './deepFreeze';
 
 /** @internal */
@@ -421,7 +420,7 @@ export const serverQrl = <T extends ServerFunction>(
 
       if (isServer) {
         // Running during SSR, we can call the function directly
-        let requestEvent = asyncRequestStore?.getStore() as RequestEvent | undefined;
+        let requestEvent = globalThis.qcAsyncRequestStore?.getStore() as RequestEvent | undefined;
 
         if (!requestEvent) {
           const contexts = [useQwikRouterEnv()?.ev, this, _getContextEvent()] as RequestEvent[];