shellcheck fix: tests/functional/local-overlay-store/bad-uris.sh

Author: fzakaria

maintainers/flake-module.nix

@@ -124,7 +124,6 @@
               ''^tests/functional/linux-sandbox\.sh$''
               ''^tests/functional/local-overlay-store/add-lower-inner\.sh$''
               ''^tests/functional/local-overlay-store/add-lower\.sh$''
-              ''^tests/functional/local-overlay-store/bad-uris\.sh$''
               ''^tests/functional/logging\.sh$''
               ''^tests/functional/misc\.sh$''
               ''^tests/functional/multiple-outputs\.sh$''

tests/functional/local-overlay-store/bad-uris.sh

@@ -1,11 +1,12 @@
+# shellcheck shell=bash
 source common.sh
 source ../common/init.sh
 
 requireEnvironment
 setupConfig
 setupStoreDirs
 
-mkdir -p $TEST_ROOT/bad_test
+mkdir -p "$TEST_ROOT"/bad_test
 badTestRoot=$TEST_ROOT/bad_test
 storeBadRoot="local-overlay://?root=$badTestRoot&lower-store=$storeA&upper-layer=$storeBTop"
 storeBadLower="local-overlay://?root=$storeBRoot&lower-store=$badTestRoot&upper-layer=$storeBTop"
@@ -18,7 +19,8 @@ declare -a storesBad=(
 TODO_NixOS
 
 for i in "${storesBad[@]}"; do
-    echo $i
+    echo "$i"
+    # shellcheck disable=SC2119
     execUnshare <<EOF
         source common.sh
         setupStoreDirs