fix: misc-throw-by-value-catch-by-reference (#338)

kobayu858 · web-flow · commit dc67f828bcf7 · 2024-11-08T18:58:53.000+09:00
Signed-off-by: kobayu858 &lt;yutaro.kobayashi@tier4.jp&gt;
diff --git a/eagleye_core/coordinate/src/convertheight.cpp b/eagleye_core/coordinate/src/convertheight.cpp
@@ -48,7 +48,7 @@ double ConvertHeight::convert2altitude()
     GeographicLib::Geoid egm2008("egm2008-1");
     converted_height = egm2008.ConvertHeight(_latitude, _longitude, _height, GeographicLib::Geoid::ELLIPSOIDTOGEOID);
   }
-  catch (const GeographicLib::GeographicErr err)
+  catch (const GeographicLib::GeographicErr& err)
   {
     std::cerr << "\033[31;1mError: Failed to convert height from Ellipsoid to Altitude. " << err.what() << std::endl;
     exit(4);
@@ -64,7 +64,7 @@ double ConvertHeight::convert2ellipsoid()
     GeographicLib::Geoid egm2008("egm2008-1");
     converted_height = egm2008.ConvertHeight(_latitude, _longitude, _height, GeographicLib::Geoid::GEOIDTOELLIPSOID);
   }
-  catch (const GeographicLib::GeographicErr err)
+  catch (const GeographicLib::GeographicErr& err)
   {
     std::cerr << "\033[31;1mError: Failed to convert height from Ellipsoid to Altitude. " << err.what() << std::endl;
     exit(4);

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ double ConvertHeight::convert2altitude()`
`48`	`48`	`GeographicLib::Geoid egm2008("egm2008-1");`
`49`	`49`	`converted_height = egm2008.ConvertHeight(_latitude, _longitude, _height, GeographicLib::Geoid::ELLIPSOIDTOGEOID);`
`50`	`50`	`}`
`51`		`- catch (const GeographicLib::GeographicErr err)`
	`51`	`+ catch (const GeographicLib::GeographicErr& err)`
`52`	`52`	`{`
`53`	`53`	`std::cerr << "\033[31;1mError: Failed to convert height from Ellipsoid to Altitude. " << err.what() << std::endl;`
`54`	`54`	`exit(4);`
`@@ -64,7 +64,7 @@ double ConvertHeight::convert2ellipsoid()`
`64`	`64`	`GeographicLib::Geoid egm2008("egm2008-1");`
`65`	`65`	`converted_height = egm2008.ConvertHeight(_latitude, _longitude, _height, GeographicLib::Geoid::GEOIDTOELLIPSOID);`
`66`	`66`	`}`
`67`		`- catch (const GeographicLib::GeographicErr err)`
	`67`	`+ catch (const GeographicLib::GeographicErr& err)`
`68`	`68`	`{`
`69`	`69`	`std::cerr << "\033[31;1mError: Failed to convert height from Ellipsoid to Altitude. " << err.what() << std::endl;`
`70`	`70`	`exit(4);`