From 2144f4335c544be218759b77b3194ab43d756b02 Mon Sep 17 00:00:00 2001 From: Sven van Haastregt Date: Fri, 26 Sep 2025 16:45:54 +0200 Subject: [PATCH] Fix error propagation in parseSPIRV (#3362) d54f77c5 ("[NFC] Split of SPT and SPIR-V in header parsing (#2316)", 2024-03-11) made a copy of the error log, with the presumably unintended consequence that errors are no longer propagated back to the SPIRVModule itself. --- lib/SPIRV/libSPIRV/SPIRVModule.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/SPIRV/libSPIRV/SPIRVModule.cpp b/lib/SPIRV/libSPIRV/SPIRVModule.cpp index ea82be35e..7dd18a2d3 100644 --- a/lib/SPIRV/libSPIRV/SPIRVModule.cpp +++ b/lib/SPIRV/libSPIRV/SPIRVModule.cpp @@ -2572,7 +2572,7 @@ std::istream &SPIRVModuleImpl::parseSPIRV(std::istream &I) { SPIRVWord Header[5] = {0}; I.read(reinterpret_cast(&Header), sizeof(Header)); - SPIRVErrorLog ErrorLog = MI.getErrorLog(); + SPIRVErrorLog &ErrorLog = MI.getErrorLog(); if (!ErrorLog.checkError(!I.eof(), SPIRVEC_InvalidModule, "input file is empty") || !ErrorLog.checkError(!I.fail(), SPIRVEC_InvalidModule,