Skip to content

Commit 8769fb9

Browse files
authored
Update contribution-guide.md
1 parent e194438 commit 8769fb9

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

source/developer/contribution-guide.md

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -51,17 +51,17 @@ When submitting a PR, check that:
5151
After submitting a PR, before it is merged:
5252

5353
1. Automated build process must pass
54-
- If the build fails, check the error log to narrow down the reason
54+
- If the build fails, check the error log to narrow down the reason .
5555
- Sometimes one of the multiple build tests will randomly fail due to issues in Travis CI. If you see just one build failure and no clear error message, it may be a random issue. Add a comment so the reviewer for your change can re-run the build for you, or close the PR and re-submit and that typically clears the issue.
5656
2. PM review must pass
5757
- A Product Manager will review the pull request to make sure it:
58-
- fits with our product roadmap
59-
- works as expected
60-
- meets [UX guidelines](https://docs.mattermost.com/developer/fx-guidelines.html)
58+
- Fits with our product roadmap
59+
- Works as expected
60+
- Meets [UX guidelines](https://docs.mattermost.com/developer/fx-guidelines.html)
6161
- The Product Manager may come back with some bugs or UI improvements to fix before the pull request moves on to dev review.
6262
3. Dev review must pass
63-
- Two developers will review the pull request and either give feedback or approve the PR
64-
- Any comments will need to be addressed before the pull request is ready to merge
63+
- Two developers will review the pull request and either give feedback or approve the PR.
64+
- Any comments will need to be addressed before the pull request is ready to merge.
6565

6666
If you've included your mailing address in the signed [Contributor License Agreement](https://www.mattermost.org/mattermost-contributor-agreement/), you may receive a [Limited Edition Mattermost Mug](https://forum.mattermost.org/t/limited-edition-mattermost-mugs/143) as a thank you gift after your first pull request is merged.
6767

@@ -70,6 +70,6 @@ If you've included your mailing address in the signed [Contributor License Agree
7070
_Please DO NOT @-mention reviewers if they haven't yet commented on your PR._
7171
_Pull requests are reviewed in sequence._
7272

73-
**Approved reviewers include**: coreyhulen, crspeller, hmhealey, jwilander
73+
**Approved reviewers include**: coreyhulen, crspeller, enahum, grundleborg, hmhealey, jwilander
7474

75-
**Approved seconders include**: coreyhulen, crspeller, hmhealey, jwilander
75+
**Approved seconders include**: coreyhulen, crspeller, enahum, grundleborg, hmhealey, jwilander

0 commit comments

Comments
 (0)