You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: source/developer/contribution-guide.md
+8-8Lines changed: 8 additions & 8 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -51,17 +51,17 @@ When submitting a PR, check that:
51
51
After submitting a PR, before it is merged:
52
52
53
53
1. Automated build process must pass
54
-
- If the build fails, check the error log to narrow down the reason
54
+
- If the build fails, check the error log to narrow down the reason .
55
55
- Sometimes one of the multiple build tests will randomly fail due to issues in Travis CI. If you see just one build failure and no clear error message, it may be a random issue. Add a comment so the reviewer for your change can re-run the build for you, or close the PR and re-submit and that typically clears the issue.
56
56
2. PM review must pass
57
57
- A Product Manager will review the pull request to make sure it:
- The Product Manager may come back with some bugs or UI improvements to fix before the pull request moves on to dev review.
62
62
3. Dev review must pass
63
-
- Two developers will review the pull request and either give feedback or approve the PR
64
-
- Any comments will need to be addressed before the pull request is ready to merge
63
+
- Two developers will review the pull request and either give feedback or approve the PR.
64
+
- Any comments will need to be addressed before the pull request is ready to merge.
65
65
66
66
If you've included your mailing address in the signed [Contributor License Agreement](https://www.mattermost.org/mattermost-contributor-agreement/), you may receive a [Limited Edition Mattermost Mug](https://forum.mattermost.org/t/limited-edition-mattermost-mugs/143) as a thank you gift after your first pull request is merged.
67
67
@@ -70,6 +70,6 @@ If you've included your mailing address in the signed [Contributor License Agree
70
70
_Please DO NOT @-mention reviewers if they haven't yet commented on your PR._
0 commit comments