chore(cloudflare): remove unused funcs (kubernetes-sigs#5553)

Author: vflaux

provider/cloudflare/cloudflare.go

@@ -112,9 +112,7 @@ var recordTypeCustomHostnameSupported = map[string]bool{
 
 // cloudFlareDNS is the subset of the CloudFlare API that we actually use.  Add methods as required. Signatures must match exactly.
 type cloudFlareDNS interface {
-	UserDetails(ctx context.Context) (cloudflare.User, error)
 	ZoneIDByName(zoneName string) (string, error)
-	ListZones(ctx context.Context, zoneID ...string) ([]cloudflare.Zone, error)
 	ListZonesContext(ctx context.Context, opts ...cloudflare.ReqOption) (cloudflare.ZonesResponse, error)
 	ZoneDetails(ctx context.Context, zoneID string) (cloudflare.Zone, error)
 	ListDNSRecords(ctx context.Context, rc *cloudflare.ResourceContainer, rp cloudflare.ListDNSRecordsParams) ([]cloudflare.DNSRecord, *cloudflare.ResultInfo, error)
@@ -133,14 +131,6 @@ type zoneService struct {
 	service *cloudflare.API
 }
 
-func (z zoneService) UserDetails(ctx context.Context) (cloudflare.User, error) {
-	return z.service.UserDetails(ctx)
-}
-
-func (z zoneService) ListZones(ctx context.Context, zoneID ...string) ([]cloudflare.Zone, error) {
-	return z.service.ListZones(ctx, zoneID...)
-}
-
 func (z zoneService) ZoneIDByName(zoneName string) (string, error) {
 	return z.service.ZoneIDByName(zoneName)
 }

provider/cloudflare/cloudflare_test.go

@@ -47,7 +47,6 @@ type MockAction struct {
 }
 
 type mockCloudFlareClient struct {
-	User                  cloudflare.User
 	Zones                 map[string]string
 	Records               map[string]map[string]cloudflare.DNSRecord
 	Actions               []MockAction
@@ -88,7 +87,6 @@ var ExampleDomain = []cloudflare.DNSRecord{
 
 func NewMockCloudFlareClient() *mockCloudFlareClient {
 	return &mockCloudFlareClient{
-		User: cloudflare.User{ID: "xxxxxxxxxxxxxxxxxxx"},
 		Zones: map[string]string{
 			"001": "bar.com",
 			"002": "foo.com",
@@ -285,10 +283,6 @@ func (m *mockCloudFlareClient) DeleteDNSRecord(ctx context.Context, rc *cloudfla
 	return nil
 }
 
-func (m *mockCloudFlareClient) UserDetails(ctx context.Context) (cloudflare.User, error) {
-	return m.User, nil
-}
-
 func (m *mockCloudFlareClient) CustomHostnames(ctx context.Context, zoneID string, page int, filter cloudflare.CustomHostname) ([]cloudflare.CustomHostname, cloudflare.ResultInfo, error) {
 	var err error = nil
 	perPage := 50 // cloudflare-go v0 API hardcoded
@@ -372,23 +366,6 @@ func (m *mockCloudFlareClient) ZoneIDByName(zoneName string) (string, error) {
 	return "", errors.New("Unknown zone: " + zoneName)
 }
 
-func (m *mockCloudFlareClient) ListZones(ctx context.Context, zoneID ...string) ([]cloudflare.Zone, error) {
-	if m.listZonesError != nil {
-		return nil, m.listZonesError
-	}
-
-	result := []cloudflare.Zone{}
-
-	for zoneID, zoneName := range m.Zones {
-		result = append(result, cloudflare.Zone{
-			ID:   zoneID,
-			Name: zoneName,
-		})
-	}
-
-	return result, nil
-}
-
 func (m *mockCloudFlareClient) ListZonesContext(ctx context.Context, opts ...cloudflare.ReqOption) (cloudflare.ZonesResponse, error) {
 	if m.listZonesContextError != nil {
 		return cloudflare.ZonesResponse{}, m.listZonesContextError