Skip to content

Commit eb47212

Browse files
author
Christopher-Marcel Böddecker
committed
fix(SDKManager): ensure SDK Setup callbacks are called
The VRTK Logger can be configured so error logs throw exceptions, resulting in an early exit in the logging method. This fix makes sure the SDK Setup callbacks are called in that case.
1 parent f6c5c5d commit eb47212

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

Assets/VRTK/Scripts/Utilities/SDK/VRTK_SDKManager.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -661,8 +661,8 @@ private IEnumerator FinishSDKSetupLoading(VRTK_SDKSetup[] sdkSetups, VRTK_SDKSet
661661
UnloadSDKSetup();
662662

663663
const string errorMessage = "No SDK Setup from the provided list could be loaded.";
664-
VRTK_Logger.Error(errorMessage);
665664
OnLoadedSetupChanged(new LoadedSetupChangeEventArgs(previousLoadedSetup, null, errorMessage));
665+
VRTK_Logger.Error(errorMessage);
666666

667667
yield break;
668668
}
@@ -696,8 +696,8 @@ private IEnumerator FinishSDKSetupLoading(VRTK_SDKSetup[] sdkSetups, VRTK_SDKSet
696696
UnloadSDKSetup();
697697

698698
errorMessage += " There are no other Setups in the provided list to try.";
699-
VRTK_Logger.Error(errorMessage);
700699
OnLoadedSetupChanged(new LoadedSetupChangeEventArgs(previousLoadedSetup, null, errorMessage));
700+
VRTK_Logger.Error(errorMessage);
701701

702702
yield break;
703703
}

0 commit comments

Comments
 (0)