Detect jobs that failed and allow filtering them out

Author: pabs3

dashboard/assets/scripts/dashboard.js

@@ -497,9 +497,12 @@ class JobsRenderer {
 			// Ignore error jobs as they get done messages.
 			if (!info.statsElements.jobInfo.classList.contains("job-info-fatal") &&
 			    !info.statsElements.jobInfo.classList.contains("job-info-aborted") &&
+			    !info.statsElements.jobInfo.classList.contains("job-info-failed") &&
 			    /^ *[1-9][0-9]* bytes\.$|^Starting (RelabelIfAborted|MarkItemAsDone) for Item$|^Finished (WgetDownload|MoveFiles|StopHeartbeat) for Item$/.test(line)) {
 				info.statsElements.jobInfo.classList.add("job-info-done");
 				this.jobs.markFinished(ident);
+			} else if (/^ *0 bytes\.$/.test(line)) {
+				info.statsElements.jobInfo.classList.add("job-info-failed");
 			} else if (
 				/^CRITICAL (Sorry|Please report)|^ERROR Fatal exception|No space left on device|^Fatal Python error:|^(Thread|Current thread) 0x/.test(
 					line,
@@ -520,6 +523,7 @@ class JobsRenderer {
 			} else if (/^Received item /.test(line)) {
 				// Clear other statuses if a job restarts with the same job ID
 				info.statsElements.jobInfo.classList.remove("job-info-done");
+				info.statsElements.jobInfo.classList.remove("job-info-failed");
 				info.statsElements.jobInfo.classList.remove("job-info-fatal");
 				info.statsElements.jobInfo.classList.remove("job-info-aborted");
 				this.jobs.markUnfinished(ident);
@@ -1045,6 +1049,7 @@ class Dashboard {
 		const showAllHeaders = args.showAllHeaders ? Boolean(Number(args.showAllHeaders)) : true;
 		const showRunningJobs = args.showRunningJobs ? Boolean(Number(args.showRunningJobs)) : true;
 		const showFinishedJobs = args.showFinishedJobs ? Boolean(Number(args.showFinishedJobs)) : true;
+		const showFailedJobs = args.showFailedJobs ? Boolean(Number(args.showFailedJobs)) : true;
 		const showFatalJobs = args.showFatalJobs ? Boolean(Number(args.showFatalJobs)) : true;
 		const showAbortedJobs = args.showAbortedJobs ? Boolean(Number(args.showAbortedJobs)) : true;
 		const loadRecent = args.loadRecent ? Boolean(Number(args.loadRecent)) : true;
@@ -1117,6 +1122,7 @@ class Dashboard {
 
 		this.showRunningJobs(showRunningJobs);
 		this.showFinishedJobs(showFinishedJobs);
+		this.showFailedJobs(showFailedJobs);
 		this.showFatalJobs(showFatalJobs);
 		this.showAbortedJobs(showAbortedJobs);
 
@@ -1250,6 +1256,8 @@ ${String(kbPerSec).padStart(3, "0")} KB/s`;
 			ds.showRunningJobs(!byId("show-running-jobs").checked);
 		} else if (ev.which === 100 /* d */) {
 			ds.showFinishedJobs(!byId("show-finished-jobs").checked);
+		} else if (ev.which === 98 /* b */) {
+			ds.showFailedJobs(!byId("show-failed-jobs").checked);
 		} else if (ev.which === 99 /* c */) {
 			ds.showFatalJobs(!byId("show-fatal-jobs").checked);
 		} else if (ev.which === 115 /* s */) {
@@ -1324,6 +1332,11 @@ ${String(kbPerSec).padStart(3, "0")} KB/s`;
 		byId('hide-done').sheet.disabled = value;
 	}
 
+	showFailedJobs(value) {
+		byId('show-failed-jobs').checked = value;
+		byId('hide-failed').sheet.disabled = value;
+	}
+
 	showFatalJobs(value) {
 		byId('show-fatal-jobs').checked = value;
 		byId('hide-fatal').sheet.disabled = value;

dashboard/dashboard.html

@@ -136,6 +136,10 @@
 	color: #DD0000 !important;
 }
 
+.job-info-failed {
+	color: #CC7676 !important;
+}
+
 .inline-stat {
 	/* Needed for 'Align!' feature */
 	display: inline-block;
@@ -408,6 +412,7 @@
 <style id="hide-running">
 .log-container:not(
 	:has(.job-info-done),
+	:has(.job-info-failed),
 	:has(.job-info-fatal),
 	:has(.job-info-aborted)
 ) {
@@ -421,6 +426,12 @@
 	content-visibility: hidden;
 }
 </style>
+<style id="hide-failed">
+.log-container:has(.job-info-failed) {
+	display: none;
+	content-visibility: hidden;
+}
+</style>
 <style id="hide-fatal">
 .log-container:has(.job-info-fatal) {
 	display: none;
@@ -452,6 +463,8 @@
 			<label for="show-running-jobs">Running</label><br>
 			<input type="checkbox" id="show-finished-jobs" onclick="ds.showFinishedJobs(this.checked);" accesskey="d">
 			<label class="job-info-done" for="show-finished-jobs">Finished</label><br>
+			<input type="checkbox" id="show-failed-jobs" onclick="ds.showFailedJobs(this.checked);" accesskey="b">
+			<label class="job-info-failed" for="show-failed-jobs">Failed</label><br>
 			<input type="checkbox" id="show-fatal-jobs" onclick="ds.showFatalJobs(this.checked);" accesskey="c">
 			<label class="job-info-fatal" for="show-fatal-jobs">Fatal</label><br>
 			<input type="checkbox" id="show-aborted-jobs" onclick="ds.showAbortedJobs(this.checked);" accesskey="s">
@@ -483,6 +496,7 @@
 				The color coding for the job header is:
 					in progress,
 					<span class="job-info-done">finished normally</span>,
+					<span class="job-info-failed">finished with failure</span>,
 					<span class="job-info-aborted">finished with abort</span>,
 					<span class="job-info-fatal">finished with fatal exception</span>.
 			</p>
@@ -509,6 +523,7 @@
 				<li><kbd>h</kbd> - show/hide headers for hidden job logs
 				<li><kbd>r</kbd> - show/hide header+log for running jobs
 				<li><kbd>d</kbd> - show/hide header+log for finished jobs
+				<li><kbd>b</kbd> - show/hide header+log for failed jobs
 				<li><kbd>c</kbd> - show/hide header+log for fatal jobs
 				<li><kbd>s</kbd> - show/hide header+log for aborted jobs
 				<li><kbd>?</kbd> - show/hide help text
@@ -531,6 +546,7 @@
 				<li>To initially hide different job types, add these to the dashboard URL. The default is to show them.
 					<kbd><span class="url-q-or-amp">?</span>showRunningJobs=0</kbd>
 					<kbd><span class="url-q-or-amp">?</span>showFinishedJobs=0</kbd>
+					<kbd><span class="url-q-or-amp">?</span>showFailedJobs=0</kbd>
 					<kbd><span class="url-q-or-amp">?</span>showFatalJobs=0</kbd>
 					<kbd><span class="url-q-or-amp">?</span>showAbortedJobs=0</kbd>
 				</li>